Chromium Code Reviews| Index: content/browser/gpu/gpu_ipc_browsertests.cc |
| diff --git a/content/browser/gpu/gpu_ipc_browsertests.cc b/content/browser/gpu/gpu_ipc_browsertests.cc |
| index 817d73229b481d8fc211a1d5c0a4dce1482b768e..f50b2bbb3368d0355d7edb5f771be39f32aedfe0 100644 |
| --- a/content/browser/gpu/gpu_ipc_browsertests.cc |
| +++ b/content/browser/gpu/gpu_ipc_browsertests.cc |
| @@ -91,6 +91,12 @@ class BrowserGpuChannelHostFactoryTest : public ContentBrowserTest { |
| ContentBrowserTest::SetUpOnMainThread(); |
| } |
| + void SetUpCommandLine(base::CommandLine* command_line) override { |
| + // Start all tests without a gpu channel so that the tests exercise a |
| + // consistent codepath. |
| + command_line->AppendSwitchASCII(switches::kDisableGpuEarlyInit, ""); |
|
no sievers
2015/03/26 23:16:19
nit: AppendSwitch(switches::kDisableGpuEarlyInit)
halliwell
2015/03/26 23:25:00
Done.
|
| + } |
| + |
| void OnContextLost(const base::Closure callback, int* counter) { |
| (*counter)++; |
| callback.Run(); |
| @@ -134,7 +140,7 @@ class BrowserGpuChannelHostFactoryTest : public ContentBrowserTest { |
| }; |
| // Fails since UI Compositor establishes a GpuChannel. |
| -IN_PROC_BROWSER_TEST_F(BrowserGpuChannelHostFactoryTest, DISABLED_Basic) { |
| +IN_PROC_BROWSER_TEST_F(BrowserGpuChannelHostFactoryTest, Basic) { |
| DCHECK(!IsChannelEstablished()); |
| EstablishAndWait(); |
| EXPECT_TRUE(GetGpuChannel() != NULL); |
| @@ -142,7 +148,7 @@ IN_PROC_BROWSER_TEST_F(BrowserGpuChannelHostFactoryTest, DISABLED_Basic) { |
| // Fails since UI Compositor establishes a GpuChannel. |
| IN_PROC_BROWSER_TEST_F(BrowserGpuChannelHostFactoryTest, |
| - DISABLED_EstablishAndTerminate) { |
| + EstablishAndTerminate) { |
| DCHECK(!IsChannelEstablished()); |
| base::RunLoop run_loop; |
| GetFactory()->EstablishGpuChannel(kInitCause, run_loop.QuitClosure()); |
| @@ -155,7 +161,7 @@ IN_PROC_BROWSER_TEST_F(BrowserGpuChannelHostFactoryTest, |
| #if !defined(OS_ANDROID) |
| // Fails since UI Compositor establishes a GpuChannel. |
| IN_PROC_BROWSER_TEST_F(BrowserGpuChannelHostFactoryTest, |
| - DISABLED_AlreadyEstablished) { |
| + AlreadyEstablished) { |
| DCHECK(!IsChannelEstablished()); |
| scoped_refptr<GpuChannelHost> gpu_channel = |
| GetFactory()->EstablishGpuChannelSync(kInitCause); |
| @@ -172,7 +178,7 @@ IN_PROC_BROWSER_TEST_F(BrowserGpuChannelHostFactoryTest, |
| // Fails since UI Compositor establishes a GpuChannel. |
| IN_PROC_BROWSER_TEST_F(BrowserGpuChannelHostFactoryTest, |
| - DISABLED_CrashAndRecover) { |
| + CrashAndRecover) { |
| DCHECK(!IsChannelEstablished()); |
| EstablishAndWait(); |
| scoped_refptr<GpuChannelHost> host = GetGpuChannel(); |