Issue 1038743003: gpu: Fix some jmadill's TODOs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1038743003: gpu: Fix some jmadill's TODOs. (Closed)

Created:
5 years, 9 months ago by tfarina

Modified:
5 years, 9 months ago

Reviewers:
no sievers, Jamie Madill

CC:
chromium-reviews, piman+watch_chromium.org, Jamie Madill, Dirk Pranke

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

gpu: Fix some jmadill's TODOs. BUG=None TEST=./build/gyp_chromium still works R=sievers@chromium.org Committed: https://crrev.com/1275e81571edae39c63505d4f884b9058f8f380c Cr-Commit-Position: refs/heads/master@{#322445}

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -13 lines)			Patch
	M	gpu/angle_end2end_tests_main.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	gpu/gpu.gyp	View		4 chunks	+7 lines, -12 lines	0 comments	Download

Total messages: 8 (2 generated)

Jamie Madill

Thanks for taking this on. Looks good from my perspective.

5 years, 9 months ago (2015-03-26 12:26:58 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1038743003/1

5 years, 9 months ago (2015-03-26 18:15:00 UTC) #6

commit-bot: I haz the power

5 years, 9 months ago (2015-03-26 19:25:58 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/1275e81571edae39c63505d4f884b9058f8f380c
Cr-Commit-Position: refs/heads/master@{#322445}