Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1038743002: Split the chrome_official_build target in 2 (Closed)

Created:
5 years, 9 months ago by Sébastien Marchand
Modified:
5 years, 9 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Split the chrome_official_build target in 2 BUG=309849 Committed: https://crrev.com/a72a974dfd29464304f024277bcac0719c41884f Cr-Commit-Position: refs/heads/master@{#322270}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Re-add app_installer_unittests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -16 lines) Patch
M build/all.gyp View 1 3 chunks +22 lines, -16 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Sébastien Marchand
PTAL.
5 years, 9 months ago (2015-03-25 21:14:50 UTC) #2
scottmg
https://codereview.chromium.org/1038743002/diff/1/build/all.gyp File build/all.gyp (left): https://codereview.chromium.org/1038743002/diff/1/build/all.gyp#oldcode1169 build/all.gyp:1169: '../chrome/chrome.gyp:app_installer_unittests', this one got lost?
5 years, 9 months ago (2015-03-25 21:17:29 UTC) #3
Sébastien Marchand
oops, good catch. PTAnL.
5 years, 9 months ago (2015-03-25 21:22:52 UTC) #4
scottmg
lgtm
5 years, 9 months ago (2015-03-25 21:29:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1038743002/20001
5 years, 9 months ago (2015-03-25 21:42:10 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-26 00:15:25 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 00:16:10 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/a72a974dfd29464304f024277bcac0719c41884f
Cr-Commit-Position: refs/heads/master@{#322270}

Powered by Google App Engine
This is Rietveld 408576698