Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1038703002: Revert of content: Re-enable ChildDiscardableSharedMemoryManagerBrowserTest.LockMemory test. (Closed)

Created:
5 years, 9 months ago by reveman
Modified:
5 years, 9 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of content: Re-enable ChildDiscardableSharedMemoryManagerBrowserTest.LockMemory test. (patchset #1 id:1 of https://codereview.chromium.org/1033553003/) Reason for revert: Still flaky Original issue's description: > content: Re-enable ChildDiscardableSharedMemoryManagerBrowserTest.LockMemory test. > > BUG= > TEST=content_browsertests --gtest_filter=ChildDiscardableSharedMemoryManagerBrowserTest.LockMemory > > Committed: https://crrev.com/98e563846f88a2df7107e170381a6a5e8bd4454b > Cr-Commit-Position: refs/heads/master@{#322122} TBR=avi@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/c08010e76b0f9c77c336810be25373b95c91d7bb Cr-Commit-Position: refs/heads/master@{#322175}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/child/child_discardable_shared_memory_manager_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
reveman
Created Revert of content: Re-enable ChildDiscardableSharedMemoryManagerBrowserTest.LockMemory test.
5 years, 9 months ago (2015-03-25 16:51:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1038703002/1
5 years, 9 months ago (2015-03-25 16:51:20 UTC) #2
Avi (use Gerrit)
lgtm
5 years, 9 months ago (2015-03-25 16:51:39 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-25 16:52:06 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c08010e76b0f9c77c336810be25373b95c91d7bb Cr-Commit-Position: refs/heads/master@{#322175}
5 years, 9 months ago (2015-03-25 16:52:54 UTC) #5
James Cook
On 2015/03/25 16:52:54, I haz the power (commit-bot) wrote: > Patchset 1 (id:??) landed as ...
5 years, 9 months ago (2015-03-25 18:04:21 UTC) #6
reveman
5 years, 9 months ago (2015-03-25 18:11:39 UTC) #7
Message was sent while issue was closed.
On 2015/03/25 at 18:04:21, jamescook wrote:
> On 2015/03/25 16:52:54, I haz the power (commit-bot) wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/c08010e76b0f9c77c336810be25373b95c91d7bb
> > Cr-Commit-Position: refs/heads/master@{#322175}
> 
> Is there a bug for this issue?
> 
> I'm the chrome-on-chromeos gardener today and this test was reliably failing
on the cros_trunk bot, so I'd like to follow along. Here's the bot:
http://master.chrome.corp.google.com:8011/builders/cros%20trunk

crbug.com/459703, sorry it should have been in the BUG= field.

Powered by Google App Engine
This is Rietveld 408576698