Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 1038693003: Remove sfnt dependency from xps gyp tartget. (Closed)

Created:
5 years, 9 months ago by bungeman-skia
Modified:
5 years, 9 months ago
Reviewers:
hal.canary
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove sfnt dependency from xps gyp tartget. The xps gyp target depends on skia_lib, which in turn contains the sfnt target (and re-exports it settings). As a result, it should not separately depend on the sfnt target. This currently isn't causing issues because the sfnt target is mostly header only, but any code in it may be duplicated. Committed: https://skia.googlesource.com/skia/+/05035d43e74a787711db6c18ea97df4d3a075116

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M gyp/xps.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
bungeman-skia
Things outside skia_lib should depend on skia_lib and not directly on anything inside skia_lib.
5 years, 9 months ago (2015-03-25 21:39:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1038693003/1
5 years, 9 months ago (2015-03-25 21:39:42 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-25 21:39:43 UTC) #5
hal.canary
lgtm
5 years, 9 months ago (2015-03-25 21:40:35 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 21:48:08 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/05035d43e74a787711db6c18ea97df4d3a075116

Powered by Google App Engine
This is Rietveld 408576698