Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1038663002: Reland "Allow compaction when incremental marking is on." (Closed)

Created:
5 years, 9 months ago by ulan
Modified:
5 years, 9 months ago
CC:
v8-dev, rogerj, Michael Achenbach
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland "Allow compaction when incremental marking is on." BUG=chromium:450824 LOG=NO Committed: https://crrev.com/89ba65fd4970130eea02b675e448a8219ae3d0dd Cr-Commit-Position: refs/heads/master@{#27451}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -12 lines) Patch
M src/heap/incremental-marking.h View 2 chunks +2 lines, -4 lines 0 comments Download
M src/heap/incremental-marking.cc View 5 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
ulan
PTAL
5 years, 9 months ago (2015-03-25 15:15:36 UTC) #2
Hannes Payer (out of office)
lgtm
5 years, 9 months ago (2015-03-25 15:27:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1038663002/1
5 years, 9 months ago (2015-03-25 15:28:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-25 15:59:34 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/89ba65fd4970130eea02b675e448a8219ae3d0dd Cr-Commit-Position: refs/heads/master@{#27451}
5 years, 9 months ago (2015-03-25 15:59:43 UTC) #7
Igor Sheludko
5 years, 8 months ago (2015-03-27 06:43:56 UTC) #8
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1039573003/ by ishell@chromium.org.

The reason for reverting is: Reverting risky GC changes that block v8 roll..

Powered by Google App Engine
This is Rietveld 408576698