Add support for using alternative backends (like DirectX) when creating a GrGpu.

Add support for using alternative backends (like DirectX) when creating a GrGpu.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/384181c8100e059a94b1708f8af766e598fab3d9

[egdaniel, 2015-03-25 13:35:24]

egdaniel@google.com changed reviewers:
+ bsalomon@google.com, jvanverth@google.com, robertphillips@google.com

[robertphillips, 2015-03-25 13:58:24]

lgtm

https://codereview.chromium.org/1038643002/diff/1/src/gpu/GrGpuFactory.cpp
File src/gpu/GrGpuFactory.cpp (right):

https://codereview.chromium.org/1038643002/diff/1/src/gpu/GrGpuFactory.cpp#ne...
src/gpu/GrGpuFactory.cpp:48: GrGpu* GrGpu::Create(GrBackend backend,
GrBackendContext backendContext, GrContext* context) {
SkAssert(backend < kMaxNumBackends); ?

[bsalomon, 2015-03-25 14:11:54]

https://codereview.chromium.org/1038643002/diff/1/src/gpu/GrGpuFactory.cpp
File src/gpu/GrGpuFactory.cpp (right):

https://codereview.chromium.org/1038643002/diff/1/src/gpu/GrGpuFactory.cpp#ne...
src/gpu/GrGpuFactory.cpp:17: static GrGpu* GLGpuCreate(GrBackendContext
backendContext, GrContext* context) {
gl_cpu_create (static_functions_use_hacker_naming)

https://codereview.chromium.org/1038643002/diff/1/src/gpu/GrGpuFactory.cpp#ne...
src/gpu/GrGpuFactory.cpp:44: GrGpuFactoryRegistrar::GrGpuFactoryRegistrar(int i,
CreateGpuProc proc) {
Seems a bit weird to have a fixed sized array. Why not var-length? Also, should
we have a mutex around insertion and access? Not worried about perf here.

[robertphillips, 2015-03-25 16:01:02]

https://codereview.chromium.org/1038643002/diff/1/src/gpu/GrGpuFactory.cpp
File src/gpu/GrGpuFactory.cpp (right):

https://codereview.chromium.org/1038643002/diff/1/src/gpu/GrGpuFactory.cpp#ne...
src/gpu/GrGpuFactory.cpp:44: GrGpuFactoryRegistrar::GrGpuFactoryRegistrar(int i,
CreateGpuProc proc) {
On 2015/03/25 14:11:54, bsalomon wrote:
> Seems a bit weird to have a fixed sized array. Why not var-length? Also,
should
> we have a mutex around insertion and access? Not worried about perf here.

I suggest we keep it simple for this go round and expand the functionality if we
need it in the future.

[egdaniel, 2015-03-25 16:17:17]

https://codereview.chromium.org/1038643002/diff/1/src/gpu/GrGpuFactory.cpp
File src/gpu/GrGpuFactory.cpp (right):

https://codereview.chromium.org/1038643002/diff/1/src/gpu/GrGpuFactory.cpp#ne...
src/gpu/GrGpuFactory.cpp:17: static GrGpu* GLGpuCreate(GrBackendContext
backendContext, GrContext* context) {
On 2015/03/25 14:11:54, bsalomon wrote:
> gl_cpu_create (static_functions_use_hacker_naming)

Done.

https://codereview.chromium.org/1038643002/diff/1/src/gpu/GrGpuFactory.cpp#ne...
src/gpu/GrGpuFactory.cpp:44: GrGpuFactoryRegistrar::GrGpuFactoryRegistrar(int i,
CreateGpuProc proc) {
On 2015/03/25 16:01:02, robertphillips wrote:
> On 2015/03/25 14:11:54, bsalomon wrote:
> > Seems a bit weird to have a fixed sized array. Why not var-length? Also,
> should
> > we have a mutex around insertion and access? Not worried about perf here.
> 
> I suggest we keep it simple for this go round and expand the functionality if
we
> need it in the future.

Agree with Rob on the simple approach for now. Also if we keep this version for
now, we shouldn't need any mutexes.

https://codereview.chromium.org/1038643002/diff/1/src/gpu/GrGpuFactory.cpp#ne...
src/gpu/GrGpuFactory.cpp:48: GrGpu* GrGpu::Create(GrBackend backend,
GrBackendContext backendContext, GrContext* context) {
On 2015/03/25 13:58:24, robertphillips wrote:
> SkAssert(backend < kMaxNumBackends); ?

Done.

[bsalomon, 2015-03-25 20:23:03]

On 2015/03/25 16:17:17, egdaniel wrote:
> https://codereview.chromium.org/1038643002/diff/1/src/gpu/GrGpuFactory.cpp
> File src/gpu/GrGpuFactory.cpp (right):
> 
>
https://codereview.chromium.org/1038643002/diff/1/src/gpu/GrGpuFactory.cpp#ne...
> src/gpu/GrGpuFactory.cpp:17: static GrGpu* GLGpuCreate(GrBackendContext
> backendContext, GrContext* context) {
> On 2015/03/25 14:11:54, bsalomon wrote:
> > gl_cpu_create (static_functions_use_hacker_naming)
> 
> Done.
> 
>
https://codereview.chromium.org/1038643002/diff/1/src/gpu/GrGpuFactory.cpp#ne...
> src/gpu/GrGpuFactory.cpp:44: GrGpuFactoryRegistrar::GrGpuFactoryRegistrar(int
i,
> CreateGpuProc proc) {
> On 2015/03/25 16:01:02, robertphillips wrote:
> > On 2015/03/25 14:11:54, bsalomon wrote:
> > > Seems a bit weird to have a fixed sized array. Why not var-length? Also,
> > should
> > > we have a mutex around insertion and access? Not worried about perf here.
> > 
> > I suggest we keep it simple for this go round and expand the functionality
if
> we
> > need it in the future.
> 
> Agree with Rob on the simple approach for now. Also if we keep this version
for
> now, we shouldn't need any mutexes.
> 
>
https://codereview.chromium.org/1038643002/diff/1/src/gpu/GrGpuFactory.cpp#ne...
> src/gpu/GrGpuFactory.cpp:48: GrGpu* GrGpu::Create(GrBackend backend,
> GrBackendContext backendContext, GrContext* context) {
> On 2015/03/25 13:58:24, robertphillips wrote:
> > SkAssert(backend < kMaxNumBackends); ?
> 
> Done.

lgtm

[egdaniel, 2015-03-26 14:42:46]

The CQ bit was checked by egdaniel@google.com

[egdaniel, 2015-03-26 14:42:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1038643002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2015-03-26 14:42:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1038643002/40001

[commit-bot: I haz the power, 2015-03-26 14:44:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-26 14:44:02]

Try jobs failed on following builders:
  Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...)

[egdaniel, 2015-03-26 15:09:23]

The CQ bit was checked by egdaniel@google.com

[egdaniel, 2015-03-26 15:09:24]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com,
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1038643002/#ps60001
(title: " ")

[commit-bot: I haz the power, 2015-03-26 15:09:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1038643002/60001

[commit-bot: I haz the power, 2015-03-26 16:09:44]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/384181c8100e059a94b1708f8af766e598fab3d9