dart/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart - Issue 103863004: Revert "Generate tear-off closures dynamically."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart

Issue 103863004: Revert "Generate tear-off closures dynamically." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « dart/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart ('k') | dart/sdk/lib/_internal/compiler/implementation/js_emitter/class_builder.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: dart/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart

diff --git a/dart/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart b/dart/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart

index 9b18a379801e74a635db5b6ebfc89936eac1f3ca..ac451cf397310ee9809936dbbc97bd962c695b62 100644

--- a/dart/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart

+++ b/dart/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart

@@ -369,8 +369,6 @@ class Namer implements ClosureNamer {

}

String instanceMethodName(FunctionElement element) {

- // TODO(ahe): Could this be: return invocationName(new

- // Selector.fromElement(element))?

String elementName = element.name;

String name = operatorNameToIdentifier(elementName);

if (name != elementName) return getMappedOperatorName(name);

@@ -883,7 +881,7 @@ class Namer implements ClosureNamer {

}

String isolateStaticClosureAccess(Element element) {

- return "${globalObjectFor(element)}.${getStaticClosureName(element)}()";

+ return "${globalObjectFor(element)}.${getStaticClosureName(element)}";

}

String globalObjectForConstant(Constant constant) => 'C';