Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 1038613002: [turbofan] Support initial step-in through debugger statement. (Closed)

Created:
5 years, 9 months ago by Michael Starzinger
Modified:
5 years, 9 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Support initial step-in through debugger statement. This adapts the debugger so that the first break event starting the stepping process can come from optimized code. TurboFan supports a debugger statement and hence can be the top-most frame whenever the Debug::HandleDebugBreak handler is triggered. R=yangguo@chromium.org TEST=mjsunit/debug,cctest/test-debug Committed: https://crrev.com/7d0e5593e5a88285b109cd4d75ca15c4c0721ce9 Cr-Commit-Position: refs/heads/master@{#27447}

Patch Set 1 #

Patch Set 2 : Follow-up after rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -26 lines) Patch
M src/debug.cc View 4 chunks +8 lines, -4 lines 0 comments Download
M src/runtime/runtime-debug.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M test/cctest/cctest.status View 1 chunk +0 lines, -5 lines 0 comments Download
M test/mjsunit/debug-step-turbofan.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/mjsunit.status View 1 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Michael Starzinger
5 years, 9 months ago (2015-03-25 12:21:10 UTC) #1
Yang
On 2015/03/25 12:21:10, Michael Starzinger wrote: LGTM. Not sure whether we need a test case ...
5 years, 9 months ago (2015-03-25 13:58:34 UTC) #2
Michael Starzinger
On 2015/03/25 13:58:34, Yang wrote: > LGTM. Not sure whether we need a test case ...
5 years, 9 months ago (2015-03-25 14:37:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1038613002/2
5 years, 9 months ago (2015-03-25 14:55:02 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:2)
5 years, 9 months ago (2015-03-25 15:02:35 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 15:02:54 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7d0e5593e5a88285b109cd4d75ca15c4c0721ce9
Cr-Commit-Position: refs/heads/master@{#27447}

Powered by Google App Engine
This is Rietveld 408576698