Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 1038603002: DevTools: use v8::Isolate::RequestInterrupt instead of v8::Debug::DebugBreakForCommand (Closed)

Created:
5 years, 9 months ago by yurys
Modified:
5 years, 9 months ago
Reviewers:
alph, sergeyv, pfeldman, loislo
CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, arv+blink, vivekg
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: use v8::Isolate::RequestInterrupt instead of v8::Debug::DebugBreakForCommand RequestInterrupt provides necessary primitive for implementing command queue on embedder's side. A big advantage of this approach is that we don't have to enable debugger in order to dispatch such commands and can manage them on embedder's side. ScriptDebugServer now uses thread safe queue to store pending tasks. Although the queue is thread safe it is still caller's responsibility to make sure that ScriptDebugServer stays alive while the queue is being accessed. BUG=468735 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192543

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -18 lines) Patch
M Source/bindings/core/v8/ScriptDebugServer.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M Source/bindings/core/v8/ScriptDebugServer.cpp View 1 2 6 chunks +37 lines, -18 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
yurys
5 years, 9 months ago (2015-03-25 09:00:19 UTC) #2
yurys
5 years, 9 months ago (2015-03-25 09:00:41 UTC) #4
alph
https://codereview.chromium.org/1038603002/diff/20001/Source/bindings/core/v8/ScriptDebugServer.cpp File Source/bindings/core/v8/ScriptDebugServer.cpp (right): https://codereview.chromium.org/1038603002/diff/20001/Source/bindings/core/v8/ScriptDebugServer.cpp#newcode485 Source/bindings/core/v8/ScriptDebugServer.cpp:485: m_taskQueue->append(task); Hmm, what makes a call to InterruptRequest?
5 years, 9 months ago (2015-03-25 09:10:03 UTC) #5
yurys
https://codereview.chromium.org/1038603002/diff/20001/Source/bindings/core/v8/ScriptDebugServer.cpp File Source/bindings/core/v8/ScriptDebugServer.cpp (right): https://codereview.chromium.org/1038603002/diff/20001/Source/bindings/core/v8/ScriptDebugServer.cpp#newcode485 Source/bindings/core/v8/ScriptDebugServer.cpp:485: m_taskQueue->append(task); On 2015/03/25 09:10:03, alph wrote: > Hmm, what ...
5 years, 9 months ago (2015-03-25 09:38:49 UTC) #6
alph
Cool. lgtm
5 years, 9 months ago (2015-03-25 09:47:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1038603002/60001
5 years, 9 months ago (2015-03-25 13:45:37 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 15:22:45 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192543

Powered by Google App Engine
This is Rietveld 408576698