Rationalize coercions

lib/src/options.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// Set of flags and options passed to the compiler
 library dev_compiler.src.options;
 
 import 'dart:io';
 
 import 'package:args/args.dart';
@@ skipping 57 matching lines @@
 
   /// Whether to use covariant generics
   final bool covariantGenerics;
 
   /// Whether to inject casts between Dart assignable types.
   final bool relaxedCasts;
 
   /// Whether to use static types for code generation.
   final bool ignoreTypes;
 
+  /// Whether to wrap closures for compatibility.
+  final bool wrapClosures;
+
   RulesOptions({this.allowConstCasts: true, this.covariantGenerics: true,
-      this.relaxedCasts: true, this.ignoreTypes: false});
+      this.relaxedCasts: true, this.ignoreTypes: false,
+      this.wrapClosures: true});
 }
 
 class JSCodeOptions {
   /// Whether to emit the source map files.
   final bool emitSourceMaps;
 
   JSCodeOptions({this.emitSourceMaps: true});
 }
 
 /// General options used by the dev compiler.
@@ skipping 95 matching lines @@
   final bool onlyInferConstsAndFinalFields;
 
   /// List of non-nullable types.
   @override
   final List<String> nonnullableTypes;
 
   /// Whether to use static types for code generation.
   @override
   final bool ignoreTypes;
 
+  /// Whether to wrap closures for compatibility.
+  @override
+  final bool wrapClosures;
+
   /// Whether to emit the source map files.
   @override
   final bool emitSourceMaps;
 
   /// Location for runtime files, such as `dart_runtime.js`. By default this is
   /// inferred to be under `lib/runtime/` in the location of the `dev_compiler`
   /// package (if we can infer where that is located).
   final String runtimeDir;
 
   CompilerOptions({this.allowConstCasts: true, this.checkSdk: false,
       this.dumpInfo: false, this.dumpInfoFile, this.dumpSrcDir,
       this.forceCompile: false, this.formatOutput: false,
-      this.cheapTestFormat: false, this.ignoreTypes: false, this.outputDir,
-      this.outputDart: false, this.useColors: true,
-      this.covariantGenerics: true, this.relaxedCasts: true,
-      this.useMultiPackage: false, this.packageRoot: 'packages/',
-      this.packagePaths: const <String>[],
+      this.cheapTestFormat: false, this.ignoreTypes: false,
+      this.wrapClosures: true, this.outputDir, this.outputDart: false,
+      this.useColors: true, this.covariantGenerics: true,
+      this.relaxedCasts: true, this.useMultiPackage: false,
+      this.packageRoot: 'packages/', this.packagePaths: const <String>[],
       this.inferFromOverrides: ResolverOptions.inferFromOverridesDefault,
       this.inferTransitively: ResolverOptions.inferTransitivelyDefault,
       this.onlyInferConstsAndFinalFields: ResolverOptions.onlyInferConstAndFinalFieldsDefault,
       this.nonnullableTypes: TypeOptions.NONNULLABLE_TYPES, this.help: false,
       this.useMockSdk: false, this.dartSdkPath, this.logLevel: Level.SEVERE,
       this.emitSourceMaps: true, this.entryPointFile: null,
       this.serverMode: false, this.host: 'localhost', this.port: 8080,
       this.runtimeDir});
 }
 
@@ skipping 26 matching lines @@
 
   return new CompilerOptions(
       allowConstCasts: args['allow-const-casts'],
       checkSdk: args['sdk-check'],
       dumpInfo: dumpInfo,
       dumpInfoFile: args['dump-info-file'],
       dumpSrcDir: args['dump-src-to'],
       forceCompile: args['force-compile'] || serverMode,
       formatOutput: args['dart-gen-fmt'],
       ignoreTypes: args['ignore-types'],
+      wrapClosures: args['wrap-closures'],
       outputDart: args['dart-gen'],
       outputDir: outputDir,
       covariantGenerics: args['covariant-generics'],
       relaxedCasts: args['relaxed-casts'],
       useColors: useColors,
       useMultiPackage: args['use-multi-package'],
       packageRoot: args['package-root'],
       packagePaths: args['package-paths'].split(','),
       inferFromOverrides: args['infer-from-overrides'],
       inferTransitively: args['infer-transitively'],
@@ skipping 17 matching lines @@
   ..addFlag('allow-const-casts',
       help: 'Allow casts in const contexts', defaultsTo: true)
   ..addFlag('sdk-check',
       abbr: 's', help: 'Typecheck sdk libs', defaultsTo: false)
   ..addFlag('mock-sdk',
       abbr: 'm', help: 'Use a mock Dart SDK', defaultsTo: false)
   ..addFlag('covariant-generics',
       help: 'Use covariant generics', defaultsTo: true)
   ..addFlag('ignore-types',
       help: 'Ignore types during codegen', defaultsTo: false)
+  ..addFlag('wrap-closures', help: 'wrap closures implicitly', defaultsTo: true)
   ..addFlag('relaxed-casts',
       help: 'Cast between Dart assignable types', defaultsTo: true)
   ..addOption('nonnullable',
       abbr: 'n',
       help: 'Comma separated string of non-nullable types',
       defaultsTo: null)
   ..addFlag('infer-from-overrides',
       help: 'Infer unspecified types of fields and return types from\n'
       'definitions in supertypes',
       defaultsTo: ResolverOptions.inferFromOverridesDefault)
@@ skipping 90 matching lines @@
     // The pub-cache directory is two levels up, but we verify that the layout
     // looks correct.
     if (path.basename(dir) != 'dev_compiler') return null;
     dir = path.dirname(dir);
     if (path.basename(dir) != 'global_packages') return null;
     dir = path.dirname(dir);
     return path.join(dir, cacheDir, 'lib', 'runtime');
   }
   return null;
 }