Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 1038583004: Rationalize coercions (Closed)

Created:
5 years, 9 months ago by vsm
Modified:
5 years, 8 months ago
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Rationalize coercions This breaks out casts / coercions into: Standard (on by default) - DynamicCasts: dynamic -> T - AssignmentCasts: T x = expr; // T must be a ground type Inference (this will go away) - InferableLiteral - InferableClosure - InferableAllocation Implicit (no flag yet, but i'll add to disable by default) - DownCastComposite: Any cast to a non-ground type - DownCastImplicit: Any other implicit downcast not covered above A flag is also added to enable/disable all wrapping. This is not off by default yet, but that is the intent. R=leafp@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/f7a51364a7bdf28d013b2fdf26b4e036c2d18ded

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+664 lines, -585 lines) Patch
M lib/src/checker/checker.dart View 1 1 chunk +3 lines, -1 line 0 comments Download
M lib/src/checker/rules.dart View 1 3 chunks +2 lines, -8 lines 0 comments Download
M lib/src/codegen/reify_coercions.dart View 2 chunks +8 lines, -5 lines 0 comments Download
M lib/src/info.dart View 1 4 chunks +118 lines, -49 lines 0 comments Download
M lib/src/options.dart View 1 2 5 chunks +16 lines, -6 lines 0 comments Download
M test/checker/checker_test.dart View 1 40 chunks +136 lines, -135 lines 0 comments Download
M test/checker/inferred_type_test.dart View 1 2 18 chunks +27 lines, -27 lines 0 comments Download
M test/codegen/expect/DeltaBlue.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M test/codegen/expect/fieldtest.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M test/codegen/expect/methods.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M test/codegen/expect/sunflower/sunflower.txt View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M test/dart_codegen/expect/_internal/iterable.dart View 12 chunks +14 lines, -14 lines 0 comments Download
M test/dart_codegen/expect/async/async_error.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M test/dart_codegen/expect/async/broadcast_stream_controller.dart View 10 chunks +11 lines, -11 lines 0 comments Download
M test/dart_codegen/expect/async/future.dart View 8 chunks +10 lines, -10 lines 0 comments Download
M test/dart_codegen/expect/async/future_impl.dart View 13 chunks +23 lines, -23 lines 0 comments Download
M test/dart_codegen/expect/async/schedule_microtask.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M test/dart_codegen/expect/async/stream.dart View 18 chunks +25 lines, -25 lines 0 comments Download
M test/dart_codegen/expect/async/stream_controller.dart View 13 chunks +22 lines, -22 lines 0 comments Download
M test/dart_codegen/expect/async/stream_impl.dart View 9 chunks +12 lines, -12 lines 0 comments Download
M test/dart_codegen/expect/async/stream_pipe.dart View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M test/dart_codegen/expect/async/stream_transformers.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M test/dart_codegen/expect/async/zone.dart View 10 chunks +19 lines, -19 lines 0 comments Download
M test/dart_codegen/expect/c/c.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/dart_codegen/expect/collection/hash_map.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M test/dart_codegen/expect/collection/hash_set.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M test/dart_codegen/expect/collection/iterable.dart View 8 chunks +11 lines, -11 lines 0 comments Download
M test/dart_codegen/expect/collection/iterator.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/dart_codegen/expect/collection/linked_hash_map.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/dart_codegen/expect/collection/linked_list.dart View 6 chunks +8 lines, -8 lines 0 comments Download
M test/dart_codegen/expect/collection/list.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M test/dart_codegen/expect/collection/maps.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M test/dart_codegen/expect/collection/queue.dart View 8 chunks +10 lines, -10 lines 0 comments Download
M test/dart_codegen/expect/collection/set.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M test/dart_codegen/expect/collection/splay_tree.dart View 22 chunks +35 lines, -35 lines 0 comments Download
M test/dart_codegen/expect/convert/ascii.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M test/dart_codegen/expect/convert/codec.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M test/dart_codegen/expect/convert/converter.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/dart_codegen/expect/convert/encoding.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M test/dart_codegen/expect/convert/html_escape.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/dart_codegen/expect/convert/json.dart View 15 chunks +17 lines, -17 lines 0 comments Download
M test/dart_codegen/expect/convert/latin1.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/dart_codegen/expect/convert/line_splitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/dart_codegen/expect/convert/string_conversion.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M test/dart_codegen/expect/convert/utf.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M test/dart_codegen/expect/core/duration.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M test/dart_codegen/expect/core/errors.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M test/dart_codegen/expect/core/exceptions.dart View 4 chunks +5 lines, -5 lines 0 comments Download
M test/dart_codegen/expect/core/iterable.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/dart_codegen/expect/core/stopwatch.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/dart_codegen/expect/core/string.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/dart_codegen/expect/core/uri.dart View 28 chunks +37 lines, -37 lines 0 comments Download
M test/dart_codegen/expect/d/d.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/dart_codegen/expect/math/jenkins_smi_hash.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M test/dart_codegen/expect/math/point.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M test/dart_codegen/expect/math/rectangle.dart View 6 chunks +18 lines, -18 lines 0 comments Download
M test/dart_codegen/expect/typed_data/typed_data View 1 chunk +1 line, -1 line 0 comments Download
M test/dart_codegen/expect/types.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M test/report_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
vsm
5 years, 9 months ago (2015-03-25 19:33:05 UTC) #2
Leaf
lgtm https://codereview.chromium.org/1038583004/diff/1/lib/src/checker/rules.dart File lib/src/checker/rules.dart (right): https://codereview.chromium.org/1038583004/diff/1/lib/src/checker/rules.dart#newcode459 lib/src/checker/rules.dart:459: // FIXME(vsm): I don't think we need this ...
5 years, 9 months ago (2015-03-25 21:06:28 UTC) #3
vsm
5 years, 9 months ago (2015-03-25 21:52:03 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
f7a51364a7bdf28d013b2fdf26b4e036c2d18ded (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698