Issue 1038583003: [Effen] Add a basic layout test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1038583003: [Effen] Add a basic layout test (Closed)

Created:
5 years, 9 months ago by rafaelw

Modified:
5 years, 9 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

[Effen] Add a basic layout test BUG= R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/282bd22b57202f3941ec505c26fdec5d3044e94a

Patch Set 1 #

Total comments: 1

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -1 line)			Patch
M	sky/framework/fn.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
A	sky/tests/framework/basic.dart	View	1 chunk	+16 lines, -0 lines	0 comments	Download
A	sky/tests/framework/basic.sky	View	1 chunk	+13 lines, -0 lines	1 comment	Download
A	sky/tests/framework/basic-expected.txt	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

abarth-chromium

lgtm https://codereview.chromium.org/1038583003/diff/1/sky/tests/framework/basic.sky File sky/tests/framework/basic.sky (right): https://codereview.chromium.org/1038583003/diff/1/sky/tests/framework/basic.sky#newcode9 sky/tests/framework/basic.sky:9: window.requestAnimationFrame((_) { Why requestAnimationFrame? I guess this is ...

5 years, 9 months ago (2015-03-25 17:39:14 UTC) #3

rafaelw

5 years, 9 months ago (2015-03-25 18:03:14 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
282bd22b57202f3941ec505c26fdec5d3044e94a (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages