Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 1038583003: [Effen] Add a basic layout test (Closed)

Created:
5 years, 9 months ago by rafaelw
Modified:
5 years, 9 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -1 line) Patch
M sky/framework/fn.dart View 1 chunk +1 line, -1 line 0 comments Download
A sky/tests/framework/basic.dart View 1 chunk +16 lines, -0 lines 0 comments Download
A sky/tests/framework/basic.sky View 1 chunk +13 lines, -0 lines 1 comment Download
A sky/tests/framework/basic-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
rafaelw
5 years, 9 months ago (2015-03-25 17:36:29 UTC) #2
abarth-chromium
lgtm https://codereview.chromium.org/1038583003/diff/1/sky/tests/framework/basic.sky File sky/tests/framework/basic.sky (right): https://codereview.chromium.org/1038583003/diff/1/sky/tests/framework/basic.sky#newcode9 sky/tests/framework/basic.sky:9: window.requestAnimationFrame((_) { Why requestAnimationFrame? I guess this is ...
5 years, 9 months ago (2015-03-25 17:39:14 UTC) #3
rafaelw
5 years, 9 months ago (2015-03-25 18:03:14 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
282bd22b57202f3941ec505c26fdec5d3044e94a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698