Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 1038573004: Revert of [Android] Stop hiding the RWHV layer subtree when hiding the widget (Closed)

Created:
5 years, 9 months ago by boliu
Modified:
5 years, 9 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Android] Stop hiding the RWHV layer subtree when hiding the widget (patchset #10 id:270001 of https://codereview.chromium.org/1001573003/) Reason for revert: Breaks Android WebView which does not call ApplicationStatus.initialize Original issue's description: > [Android] Preserve the front buffer when the activity is paused > > Currently, when an activity is stopped, we explicitly hide the > foreground Tab. This is problematic, as current hiding semantics > might clear the visual front buffer before the window is hidden. > This in turn causes an unpleasant flickering during activity > transitions, e.g., when backgrounding Chrome or locking the screen. > > Wire Activity onPause/onResume notifications to WindowAndroidObservers, > allowing the foreground tab to preserve its front buffer while hiding > its web content. If the tab is explicitly hidden, or the root window > is lost, the front buffer will be cleared as usual. > > BUG=462752, 434401 > > Committed: https://crrev.com/764f31d287a4995f0c89915745f5749e1c7063af > Cr-Commit-Position: refs/heads/master@{#322052} TBR=sievers@chromium.org,dtrainor@chromium.org,tedchoc@chromium.org,piman@chromium.org,torne@chromium.org,jdduke@chromium.org BUG=462752, 434401 Committed: https://crrev.com/8f4d93f89393359f6a6f73ad06a0619027a0ca95 Cr-Commit-Position: refs/heads/master@{#322170}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -160 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/Tab.java View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/delegated_frame_evictor.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/delegated_frame_evictor.cc View 2 chunks +3 lines, -8 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.h View 2 chunks +0 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 9 chunks +40 lines, -91 lines 0 comments Download
M content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellActivity.java View 1 chunk +8 lines, -0 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/base/ActivityWindowAndroid.java View 4 chunks +1 line, -15 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/base/WindowAndroid.java View 2 chunks +0 lines, -20 lines 0 comments Download
M ui/android/window_android.h View 2 chunks +0 lines, -3 lines 0 comments Download
M ui/android/window_android.cc View 2 chunks +0 lines, -13 lines 0 comments Download
M ui/android/window_android_observer.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
boliu
Created Revert of [Android] Stop hiding the RWHV layer subtree when hiding the widget
5 years, 9 months ago (2015-03-25 14:41:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1038573004/1
5 years, 9 months ago (2015-03-25 14:42:02 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-25 16:19:14 UTC) #4
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 16:19:48 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8f4d93f89393359f6a6f73ad06a0619027a0ca95
Cr-Commit-Position: refs/heads/master@{#322170}

Powered by Google App Engine
This is Rietveld 408576698