Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7188)

Unified Diff: chrome/test/data/pdf/viewport_test.js

Issue 1038573003: OOP PDF: Reset FittingType when manually setting the zoom. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/pdf/viewport.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/pdf/viewport_test.js
diff --git a/chrome/test/data/pdf/viewport_test.js b/chrome/test/data/pdf/viewport_test.js
index 2b279a2e76f3cbda12cdbbd15a48ca42d4a7f82d..80b26c1d93adf66fa3d99f2c5609345be1a258e0 100644
--- a/chrome/test/data/pdf/viewport_test.js
+++ b/chrome/test/data/pdf/viewport_test.js
@@ -109,6 +109,27 @@ var tests = [
chrome.test.assertEq('200px', mockSizer.style.height);
chrome.test.assertEq(100, mockWindow.pageXOffset);
chrome.test.assertEq(100, mockWindow.pageYOffset);
+
+ var documentDimensions = new MockDocumentDimensions(0, 0);
+ documentDimensions.addPage(200, 200);
+ viewport.setDocumentDimensions(documentDimensions);
+ mockWindow.scrollTo(0, 0);
+ viewport.fitToPage();
+ viewport.setZoom(1);
+ chrome.test.assertEq(Viewport.FittingType.NONE, viewport.fittingType);
raymes 2015/03/26 05:52:24 can we test the fitting type after fittopage and f
Sam McNally 2015/03/26 23:05:02 Done.
+ chrome.test.assertEq('200px', mockSizer.style.width);
+ chrome.test.assertEq('200px', mockSizer.style.height);
+ chrome.test.assertEq(0, mockWindow.pageXOffset);
+ chrome.test.assertEq(0, mockWindow.pageYOffset);
+
+ viewport.fitToWidth();
+ viewport.setZoom(1);
+ chrome.test.assertEq(Viewport.FittingType.NONE, viewport.fittingType);
+ chrome.test.assertEq('200px', mockSizer.style.width);
+ chrome.test.assertEq('200px', mockSizer.style.height);
+ chrome.test.assertEq(0, mockWindow.pageXOffset);
+ chrome.test.assertEq(0, mockWindow.pageYOffset);
+
chrome.test.succeed();
},
« no previous file with comments | « chrome/browser/resources/pdf/viewport.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698