Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Issue 1038573003: OOP PDF: Reset FittingType when manually setting the zoom. (Closed)

Created:
5 years, 9 months ago by Sam McNally
Modified:
5 years, 9 months ago
Reviewers:
raymes
CC:
chromium-reviews, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

OOP PDF: Reset FittingType when manually setting the zoom. Currently, when the zoom level is set to a particular value, the viewport's fitting type is unchanged. This can cause the zoom to be manually set to one value, but be overridden if the viewport changes size as it will automatically re-apply the zoom for the fitting type. This CL fixes this by setting the fitting type to none when the zoom is set manually. BUG=470427 Committed: https://crrev.com/5050705ee16d1b3ca4acf279c0d174a5336629fb Cr-Commit-Position: refs/heads/master@{#322502}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -0 lines) Patch
M chrome/browser/resources/pdf/viewport.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/pdf/viewport_test.js View 1 12 chunks +43 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Sam McNally
5 years, 9 months ago (2015-03-25 06:58:45 UTC) #2
raymes
https://codereview.chromium.org/1038573003/diff/1/chrome/test/data/pdf/viewport_test.js File chrome/test/data/pdf/viewport_test.js (right): https://codereview.chromium.org/1038573003/diff/1/chrome/test/data/pdf/viewport_test.js#newcode119 chrome/test/data/pdf/viewport_test.js:119: chrome.test.assertEq(Viewport.FittingType.NONE, viewport.fittingType); can we test the fitting type after ...
5 years, 9 months ago (2015-03-26 05:52:24 UTC) #3
Sam McNally
https://codereview.chromium.org/1038573003/diff/1/chrome/test/data/pdf/viewport_test.js File chrome/test/data/pdf/viewport_test.js (right): https://codereview.chromium.org/1038573003/diff/1/chrome/test/data/pdf/viewport_test.js#newcode119 chrome/test/data/pdf/viewport_test.js:119: chrome.test.assertEq(Viewport.FittingType.NONE, viewport.fittingType); On 2015/03/26 05:52:24, raymes wrote: > can ...
5 years, 9 months ago (2015-03-26 23:05:02 UTC) #4
raymes
lgtm, thanks!
5 years, 9 months ago (2015-03-26 23:22:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1038573003/20001
5 years, 9 months ago (2015-03-26 23:32:12 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-27 00:01:35 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-27 00:03:04 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5050705ee16d1b3ca4acf279c0d174a5336629fb
Cr-Commit-Position: refs/heads/master@{#322502}

Powered by Google App Engine
This is Rietveld 408576698