chrome/browser/web_applications/update_shortcut_worker_win.h - Issue 1038573002: Fixed thread-unsafe use of gfx::Image in app shortcut creation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/web_applications/update_shortcut_worker_win.h

Issue 1038573002: Fixed thread-unsafe use of gfx::Image in app shortcut creation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/create_application_shortcut_view.cc ('k') | chrome/browser/web_applications/update_shortcut_worker_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/web_applications/update_shortcut_worker_win.h

diff --git a/chrome/browser/web_applications/update_shortcut_worker_win.h b/chrome/browser/web_applications/update_shortcut_worker_win.h

index 1169ee329edd36c181df77a422869d4305a13e0d..62fc6b7841572685ac5daa9b844ababa3b2245d2 100644

--- a/chrome/browser/web_applications/update_shortcut_worker_win.h

+++ b/chrome/browser/web_applications/update_shortcut_worker_win.h

@@ -70,7 +70,7 @@ class UpdateShortcutWorker : public content::NotificationObserver {

web_app::IconInfoList unprocessed_icons_;

// Cached shortcut data from the web_contents_.

- web_app::ShortcutInfo shortcut_info_;

+ scoped_ptr<web_app::ShortcutInfo> shortcut_info_;

// Our copy of profile path.

base::FilePath profile_path_;