chrome/browser/ui/app_list/app_list_view_delegate.cc - Issue 1038573002: Fixed thread-unsafe use of gfx::Image in app shortcut creation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/app_list_view_delegate.cc

Issue 1038573002: Fixed thread-unsafe use of gfx::Image in app shortcut creation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/app_list/app_list_service_mac.mm ('k') | chrome/browser/ui/views/create_application_shortcut_view.h » ('j') | chrome/browser/web_applications/web_app_mac.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/app_list/app_list_view_delegate.cc

diff --git a/chrome/browser/ui/app_list/app_list_view_delegate.cc b/chrome/browser/ui/app_list/app_list_view_delegate.cc

index 3e9377e3bbac21ac1eb8e62b821119ec21868600..848d1206ba984c9a2539a40db8f793fdd2ffad2a 100644

--- a/chrome/browser/ui/app_list/app_list_view_delegate.cc

+++ b/chrome/browser/ui/app_list/app_list_view_delegate.cc

@@ -93,11 +93,11 @@ const int kAutoLaunchDefaultTimeoutMilliSec = 50;

void CreateShortcutInWebAppDir(

const base::FilePath& app_data_dir,

base::Callback<void(const base::FilePath&)> callback,

- const web_app::ShortcutInfo& info) {

+ scoped_ptr<web_app::ShortcutInfo> info) {

content::BrowserThread::PostTaskAndReplyWithResult(

- content::BrowserThread::FILE,

- FROM_HERE,

- base::Bind(web_app::CreateShortcutInWebAppDir, app_data_dir, info),

+ content::BrowserThread::FILE, FROM_HERE,

+ base::Bind(web_app::CreateShortcutInWebAppDir, app_data_dir,

+ base::Passed(&info)),

callback);

}

#endif