Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm

Issue 1038573002: Fixed thread-unsafe use of gfx::Image in app shortcut creation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm
diff --git a/chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm b/chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm
index a17fb0100e61460e3b59ea30cc697fc91da97476..b209bee710b7e4d36880ddf906a40a431baf6eb2 100644
--- a/chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm
+++ b/chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm
@@ -265,10 +265,11 @@ bool HasAppShimHost(Profile* profile, const std::string& app_id) {
base::FilePath GetAppShimPath(Profile* profile,
const extensions::Extension* app) {
// Use a WebAppShortcutCreator to get the path.
+ scoped_ptr<web_app::ShortcutInfo> shortcut_info =
+ web_app::ShortcutInfoForExtensionAndProfile(app, profile);
web_app::WebAppShortcutCreator shortcut_creator(
web_app::GetWebAppDataDirectory(profile->GetPath(), app->id(), GURL()),
- web_app::ShortcutInfoForExtensionAndProfile(app, profile),
- extensions::FileHandlersInfo());
+ *shortcut_info, extensions::FileHandlersInfo());
return shortcut_creator.GetInternalShortcutPath();
}
@@ -649,10 +650,11 @@ IN_PROC_BROWSER_TEST_F(AppShimInteractiveTest, MAYBE_RebuildShim) {
const extensions::Extension* app = InstallPlatformApp("minimal");
// Use WebAppShortcutCreator to create a 64 bit shim.
+ scoped_ptr<web_app::ShortcutInfo> shortcut_info =
+ web_app::ShortcutInfoForExtensionAndProfile(app, profile());
web_app::WebAppShortcutCreator shortcut_creator(
web_app::GetWebAppDataDirectory(profile()->GetPath(), app->id(), GURL()),
- web_app::ShortcutInfoForExtensionAndProfile(app, profile()),
- extensions::FileHandlersInfo());
+ *shortcut_info, extensions::FileHandlersInfo());
shortcut_creator.UpdateShortcuts();
base::FilePath shim_path = shortcut_creator.GetInternalShortcutPath();
NSMutableDictionary* plist_64 = [NSMutableDictionary

Powered by Google App Engine
This is Rietveld 408576698