Fixed thread-unsafe use of gfx::Image in app shortcut creation.

chrome/browser/web_applications/web_app.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/web_applications/web_app.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/files/file_util.h"
@@ skipping 65 matching lines @@
 #endif
 
 base::FilePath GetShortcutDataDir(const web_app::ShortcutInfo& shortcut_info) {
   return web_app::GetWebAppDataDirectory(shortcut_info.profile_path,
                                          shortcut_info.extension_id,
                                          shortcut_info.url);
 }
 
 void UpdateAllShortcutsForShortcutInfo(
     const base::string16& old_app_title,
-    const web_app::ShortcutInfo& shortcut_info,
+    scoped_ptr<web_app::ShortcutInfo> shortcut_info,
     const extensions::FileHandlersInfo& file_handlers_info) {
+  base::FilePath shortcut_data_dir = GetShortcutDataDir(*shortcut_info);
   BrowserThread::PostTask(
-      BrowserThread::FILE,
-      FROM_HERE,
+      BrowserThread::FILE, FROM_HERE,
       base::Bind(&web_app::internals::UpdatePlatformShortcuts,
-                 GetShortcutDataDir(shortcut_info),
-                 old_app_title, shortcut_info, file_handlers_info));
+                 shortcut_data_dir, old_app_title, base::Passed(&shortcut_info),
+                 file_handlers_info));
 }
 
-void OnImageLoaded(web_app::ShortcutInfo shortcut_info,
+void OnImageLoaded(scoped_ptr<web_app::ShortcutInfo> shortcut_info,
                    extensions::FileHandlersInfo file_handlers_info,
                    web_app::InfoCallback callback,
                    const gfx::ImageFamily& image_family) {
   // If the image failed to load (e.g. if the resource being loaded was empty)
   // use the standard application icon.
   if (image_family.empty()) {
     gfx::Image default_icon =
         ResourceBundle::GetSharedInstance().GetImageNamed(IDR_APP_DEFAULT_ICON);
     int size = kDesiredSizes[kNumDesiredSizes - 1];
     SkBitmap bmp = skia::ImageOperations::Resize(
           *default_icon.ToSkBitmap(), skia::ImageOperations::RESIZE_BEST,
           size, size);
     gfx::ImageSkia image_skia = gfx::ImageSkia::CreateFrom1xBitmap(bmp);
     // We are on the UI thread, and this image is needed from the FILE thread,
     // for creating shortcut icon files.
     image_skia.MakeThreadSafe();
-    shortcut_info.favicon.Add(gfx::Image(image_skia));
+    shortcut_info->favicon.Add(gfx::Image(image_skia));
   } else {
-    shortcut_info.favicon = image_family;
+    shortcut_info->favicon = image_family;
   }
 
-  callback.Run(shortcut_info, file_handlers_info);
+  callback.Run(shortcut_info.Pass(), file_handlers_info);
 }
 
 void IgnoreFileHandlersInfo(
     const web_app::ShortcutInfoCallback& shortcut_info_callback,
-    const web_app::ShortcutInfo& shortcut_info,
+    scoped_ptr<web_app::ShortcutInfo> shortcut_info,
     const extensions::FileHandlersInfo& file_handlers_info) {
-  shortcut_info_callback.Run(shortcut_info);
+  shortcut_info_callback.Run(shortcut_info.Pass());
 }
 
 void ScheduleCreatePlatformShortcut(
     web_app::ShortcutCreationReason reason,
     const web_app::ShortcutLocations& locations,
-    const web_app::ShortcutInfo& shortcut_info,
+    scoped_ptr<web_app::ShortcutInfo> shortcut_info,
     const extensions::FileHandlersInfo& file_handlers_info) {
+  base::FilePath shortcut_data_dir = GetShortcutDataDir(*shortcut_info);
   BrowserThread::PostTask(
       BrowserThread::FILE, FROM_HERE,
       base::Bind(
           base::IgnoreResult(&web_app::internals::CreatePlatformShortcuts),
-          GetShortcutDataDir(shortcut_info), shortcut_info, file_handlers_info,
+          shortcut_data_dir, base::Passed(&shortcut_info), file_handlers_info,
           locations, reason));
 }
 
 }  // namespace
 
 namespace web_app {
 
 // The following string is used to build the directory name for
 // shortcuts to chrome applications (the kind which are installed
 // from a CRX).  Application shortcuts to URLs use the {host}_{path}
@@ skipping 22 matching lines @@
 
 ShortcutInfo::~ShortcutInfo() {}
 
 ShortcutLocations::ShortcutLocations()
     : on_desktop(false),
       applications_menu_location(APP_MENU_LOCATION_NONE),
       in_quick_launch_bar(false) {
 }
 
 #if defined(TOOLKIT_VIEWS)
-void GetShortcutInfoForTab(content::WebContents* web_contents,
-                           ShortcutInfo* info) {
-  DCHECK(info);  // Must provide a valid info.
-
+scoped_ptr<ShortcutInfo> GetShortcutInfoForTab(
+    content::WebContents* web_contents) {
   const FaviconTabHelper* favicon_tab_helper =
       FaviconTabHelper::FromWebContents(web_contents);
   const extensions::TabHelper* extensions_tab_helper =
       extensions::TabHelper::FromWebContents(web_contents);
   const WebApplicationInfo& app_info = extensions_tab_helper->web_app_info();
 
+  scoped_ptr<ShortcutInfo> info(new ShortcutInfo);
   info->url = app_info.app_url.is_empty() ? web_contents->GetURL() :
                                             app_info.app_url;
   info->title = app_info.title.empty() ?
       (web_contents->GetTitle().empty() ? base::UTF8ToUTF16(info->url.spec()) :
                                           web_contents->GetTitle()) :
       app_info.title;
   info->description = app_info.description;
   info->favicon.Add(favicon_tab_helper->GetFavicon());
 
   Profile* profile =
       Profile::FromBrowserContext(web_contents->GetBrowserContext());
   info->profile_path = profile->GetPath();
+
+  return info;
 }
 #endif
 
 #if !defined(OS_WIN)
 void UpdateShortcutForTabContents(content::WebContents* web_contents) {}
 #endif
 
-ShortcutInfo ShortcutInfoForExtensionAndProfile(
-    const extensions::Extension* app, Profile* profile) {
-  ShortcutInfo shortcut_info;
-  shortcut_info.extension_id = app->id();
-  shortcut_info.is_platform_app = app->is_platform_app();
-  shortcut_info.url = extensions::AppLaunchInfo::GetLaunchWebURL(app);
-  shortcut_info.title = base::UTF8ToUTF16(app->name());
-  shortcut_info.description = base::UTF8ToUTF16(app->description());
-  shortcut_info.extension_path = app->path();
-  shortcut_info.profile_path = profile->GetPath();
-  shortcut_info.profile_name =
+scoped_ptr<ShortcutInfo> ShortcutInfoForExtensionAndProfile(
+    const extensions::Extension* app,
+    Profile* profile) {
+  scoped_ptr<ShortcutInfo> shortcut_info(new ShortcutInfo);
+  shortcut_info->extension_id = app->id();
+  shortcut_info->is_platform_app = app->is_platform_app();
+  shortcut_info->url = extensions::AppLaunchInfo::GetLaunchWebURL(app);
+  shortcut_info->title = base::UTF8ToUTF16(app->name());
+  shortcut_info->description = base::UTF8ToUTF16(app->description());
+  shortcut_info->extension_path = app->path();
+  shortcut_info->profile_path = profile->GetPath();
+  shortcut_info->profile_name =
       profile->GetPrefs()->GetString(prefs::kProfileName);
-  shortcut_info.version_for_display = app->GetVersionForDisplay();
+  shortcut_info->version_for_display = app->GetVersionForDisplay();
   return shortcut_info;
 }
 
 void GetInfoForApp(const extensions::Extension* extension,
                    Profile* profile,
                    const InfoCallback& callback) {
-  web_app::ShortcutInfo shortcut_info =
-      web_app::ShortcutInfoForExtensionAndProfile(extension, profile);
+  scoped_ptr<web_app::ShortcutInfo> shortcut_info(
+      web_app::ShortcutInfoForExtensionAndProfile(extension, profile));
   const std::vector<extensions::FileHandlerInfo>* file_handlers =
       extensions::FileHandlers::GetFileHandlers(extension);
   extensions::FileHandlersInfo file_handlers_info =
       file_handlers ? *file_handlers : extensions::FileHandlersInfo();
 
   std::vector<extensions::ImageLoader::ImageRepresentation> info_list;
   for (size_t i = 0; i < kNumDesiredSizes; ++i) {
     int size = kDesiredSizes[i];
     extensions::ExtensionResource resource =
         extensions::IconsInfo::GetIconResource(
@@ skipping 25 matching lines @@
         resource,
         extensions::ImageLoader::ImageRepresentation::ALWAYS_RESIZE,
         gfx::Size(size, size),
         ui::SCALE_FACTOR_100P));
   }
 
   // |info_list| may still be empty at this point, in which case
   // LoadImageFamilyAsync will call the OnImageLoaded callback with an empty
   // image and exit immediately.
   extensions::ImageLoader::Get(profile)->LoadImageFamilyAsync(
-      extension,
-      info_list,
-      base::Bind(&OnImageLoaded, shortcut_info, file_handlers_info, callback));
+      extension, info_list,
+      base::Bind(&OnImageLoaded, base::Passed(&shortcut_info),
+                 file_handlers_info, callback));
 }
 
 void GetShortcutInfoForApp(const extensions::Extension* extension,
                            Profile* profile,
                            const ShortcutInfoCallback& callback) {
   GetInfoForApp(
       extension, profile, base::Bind(&IgnoreFileHandlersInfo, callback));
 }
 
 bool ShouldCreateShortcutFor(web_app::ShortcutCreationReason reason,
@@ skipping 83 matching lines @@
 std::string GetExtensionIdFromApplicationName(const std::string& app_name) {
   std::string prefix(kCrxAppPrefix);
   if (app_name.substr(0, prefix.length()) != prefix)
     return std::string();
   return app_name.substr(prefix.length());
 }
 
 void CreateShortcutsWithInfo(
     ShortcutCreationReason reason,
     const ShortcutLocations& locations,
-    const ShortcutInfo& shortcut_info,
+    scoped_ptr<ShortcutInfo> shortcut_info,
     const extensions::FileHandlersInfo& file_handlers_info) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
   // If the shortcut is for an application shortcut with the new bookmark app
   // flow disabled, there will be no corresponding extension.
-  if (!shortcut_info.extension_id.empty()) {
+  if (!shortcut_info->extension_id.empty()) {
     // It's possible for the extension to be deleted before we get here.
     // For example, creating a hosted app from a website. Double check that
     // it still exists.
     Profile* profile = g_browser_process->profile_manager()->GetProfileByPath(
-        shortcut_info.profile_path);
+        shortcut_info->profile_path);
     if (!profile)
       return;
 
     extensions::ExtensionRegistry* registry =
         extensions::ExtensionRegistry::Get(profile);
     const extensions::Extension* extension = registry->GetExtensionById(
-        shortcut_info.extension_id, extensions::ExtensionRegistry::EVERYTHING);
+        shortcut_info->extension_id, extensions::ExtensionRegistry::EVERYTHING);
     if (!extension)
       return;
   }
 
-  ScheduleCreatePlatformShortcut(reason, locations, shortcut_info,
+  ScheduleCreatePlatformShortcut(reason, locations, shortcut_info.Pass(),
                                  file_handlers_info);
 }
 
 void CreateNonAppShortcut(const ShortcutLocations& locations,
-                          const ShortcutInfo& shortcut_info) {
+                          scoped_ptr<ShortcutInfo> shortcut_info) {
   ScheduleCreatePlatformShortcut(SHORTCUT_CREATION_AUTOMATED, locations,
-                                 shortcut_info, extensions::FileHandlersInfo());
+                                 shortcut_info.Pass(),
+                                 extensions::FileHandlersInfo());
 }
 
 void CreateShortcuts(ShortcutCreationReason reason,
                      const ShortcutLocations& locations,
                      Profile* profile,
                      const extensions::Extension* app) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
   if (!ShouldCreateShortcutFor(reason, profile, app))
     return;
 
   GetInfoForApp(
       app, profile, base::Bind(&CreateShortcutsWithInfo, reason, locations));
 }
 
 void DeleteAllShortcuts(Profile* profile, const extensions::Extension* app) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
-  ShortcutInfo shortcut_info =
-      ShortcutInfoForExtensionAndProfile(app, profile);
+  scoped_ptr<ShortcutInfo> shortcut_info(
+      ShortcutInfoForExtensionAndProfile(app, profile));
+  base::FilePath shortcut_data_dir = GetShortcutDataDir(*shortcut_info);
   BrowserThread::PostTask(
-      BrowserThread::FILE,
-      FROM_HERE,
+      BrowserThread::FILE, FROM_HERE,
       base::Bind(&web_app::internals::DeletePlatformShortcuts,
-                 GetShortcutDataDir(shortcut_info), shortcut_info));
+                 shortcut_data_dir, base::Passed(&shortcut_info)));
 }
 
 void UpdateAllShortcuts(const base::string16& old_app_title,
                         Profile* profile,
                         const extensions::Extension* app) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
   GetInfoForApp(app,
                 profile,
                 base::Bind(&UpdateAllShortcutsForShortcutInfo, old_app_title));
@@ skipping 36 matching lines @@
 
 #if defined(OS_LINUX)
 std::string GetWMClassFromAppName(std::string app_name) {
   base::i18n::ReplaceIllegalCharactersInPath(&app_name, '_');
   base::TrimString(app_name, "_", &app_name);
   return app_name;
 }
 #endif
 
 }  // namespace web_app