Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 103853006: ES6: Tighten up Object.prototype.__proto__ (Closed)

Created:
7 years ago by arv (Not doing code reviews)
Modified:
6 years, 10 months ago
CC:
v8-dev
Visibility:
Public.

Description

ES6: Tighten up Object.prototype.__proto__ The spec requires that we throw under certain conditions. BUG=v8:3064 LOG=y R=rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19479

Patch Set 1 #

Patch Set 2 : Update comment #

Patch Set 3 : Rebase with poison pill change" #

Patch Set 4 : Use CHECK_OBJECT_COERCIBLE #

Patch Set 5 : __proto__ setter should return undefined #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -44 lines) Patch
M src/v8natives.js View 1 2 3 4 1 chunk +9 lines, -5 lines 0 comments Download
M test/mjsunit/proto-accessor.js View 1 2 3 4 1 chunk +100 lines, -39 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
arv (Not doing code reviews)
This depends on https://codereview.chromium.org/103343005/
7 years ago (2013-12-19 21:09:47 UTC) #1
arv (Not doing code reviews)
This is ready for review now that the poison pill on the setter has been ...
6 years, 10 months ago (2014-02-06 20:10:21 UTC) #2
arv (Not doing code reviews)
All these tests pass in IE11 (after removing Symbol tests) SpiderMonkey has some minor issues. ...
6 years, 10 months ago (2014-02-07 15:14:39 UTC) #3
rossberg
LGTM, will land it tomorrow
6 years, 10 months ago (2014-02-18 17:11:38 UTC) #4
arv (Not doing code reviews)
On 2014/02/18 17:11:38, rossberg wrote: > LGTM, will land it tomorrow I was hoping the ...
6 years, 10 months ago (2014-02-18 17:56:43 UTC) #5
arv (Not doing code reviews)
On 2014/02/18 17:56:43, arv wrote: > On 2014/02/18 17:11:38, rossberg wrote: > > LGTM, will ...
6 years, 10 months ago (2014-02-18 18:45:23 UTC) #6
arv (Not doing code reviews)
Updated to return undefined
6 years, 10 months ago (2014-02-18 20:15:22 UTC) #7
rossberg
6 years, 10 months ago (2014-02-19 11:59:13 UTC) #8
Message was sent while issue was closed.
Committed patchset #5 manually as r19479 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698