Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 1038463002: Add a tolerance factor to the test. (Closed)

Created:
5 years, 9 months ago by szager1
Modified:
5 years, 9 months ago
Reviewers:
dsinclair, eae
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix formatting #

Patch Set 3 : more formatting #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -91 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 2 chunks +4 lines, -1 line 0 comments Download
M LayoutTests/svg/zoom/page/zoom-zoom-coords.xhtml View 1 2 2 chunks +93 lines, -90 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
szager1
5 years, 9 months ago (2015-03-24 18:18:58 UTC) #1
eae
Code change looks good but please revert formatting changes, makes it harder to see what ...
5 years, 9 months ago (2015-03-24 18:24:12 UTC) #2
dsinclair
lgtm
5 years, 9 months ago (2015-03-24 18:24:53 UTC) #3
szager1
On 2015/03/24 18:24:12, eae wrote: > Code change looks good but please revert formatting changes, ...
5 years, 9 months ago (2015-03-24 19:39:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1038463002/40001
5 years, 9 months ago (2015-03-24 19:39:35 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/54059)
5 years, 9 months ago (2015-03-25 00:15:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1038463002/40001
5 years, 9 months ago (2015-03-25 17:40:35 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/54250)
5 years, 9 months ago (2015-03-25 17:46:38 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1038463002/60001
5 years, 9 months ago (2015-03-25 19:59:02 UTC) #16
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 22:12:00 UTC) #17
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192559

Powered by Google App Engine
This is Rietveld 408576698