Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/BUILD.gn

Issue 1038453002: Add option to export tracing events to ETW. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unnecessary blank line. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/trace_event/etw_manifest/BUILD.gn ('K') | « base/trace_event/trace_event_impl.cc ('k') | chrome/chrome_dll.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/BUILD.gn
diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn
index f6bb6b7adb7945d83a18f33f94dd086dfa5e3b68..28d36fc545d3fba4d6f2057c5cd7b7e4e45048a5 100644
--- a/chrome/BUILD.gn
+++ b/chrome/BUILD.gn
@@ -155,6 +155,7 @@ shared_library("main_dll") {
output_name = "chrome"
sources = [
+ "$root_gen_dir/base/trace_event/etw_manifest/chrome_events_win.rc",
"//base/win/dllmain.cc",
"app/chrome_command_ids.h",
"app/chrome_dll.rc",
@@ -172,6 +173,7 @@ shared_library("main_dll") {
# On Windows, link the dependencies (libraries) that make up actual
# Chromium functionality into this .dll.
":chrome_version_resources",
+ "//base/trace_event/etw_manifest:chrome_events_win",
Lei Zhang 2015/04/10 23:50:13 Should the chrome gypi files have a similar depend
Georges Khalil 2015/04/13 13:44:46 Yes, it was wrongly placed in base/base.gyp. Depen
"//chrome/app/theme:chrome_unscaled_resources",
"//chrome_elf",
"//content/app/resources",
« base/trace_event/etw_manifest/BUILD.gn ('K') | « base/trace_event/trace_event_impl.cc ('k') | chrome/chrome_dll.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698