chrome/chrome_dll.gypi - Issue 1038453002: Add option to export tracing events to ETW.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_dll.gypi

Issue 1038453002: Add option to export tracing events to ETW. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed reviewer's comments. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/chrome_dll.gypi

diff --git a/chrome/chrome_dll.gypi b/chrome/chrome_dll.gypi

index db16fa0dfd08c658d450f8a010d86e5dc3e1b0a0..e9663b9dabd3a55ac0f72e7ba57bb7ceb8997041 100644

--- a/chrome/chrome_dll.gypi

+++ b/chrome/chrome_dll.gypi

@@ -132,9 +132,12 @@

'sources': [

'app/chrome_dll.rc',

'<(SHARED_INTERMEDIATE_DIR)/chrome_version/chrome_dll_version.rc',

Nico 2015/03/31 22:26:08 huh, this looks wrong to me. I haven't seen <(SHAR

Georges Khalil 2015/04/01 16:47:04 The diff is misleading as this is actually an exis

+ # ETW Manifest.

+ '<(SHARED_INTERMEDIATE_DIR)/base/trace_event/etw_manifest/chrome_events_win.rc',

# Cursors.

'<(SHARED_INTERMEDIATE_DIR)/ui/resources/ui_unscaled_resources.rc',

« no previous file with comments | « chrome/BUILD.gn ('k') | content/app/content_main_runner.cc » ('j') | no next file with comments »