base/trace_event/etw_manifest/BUILD/message_compiler.py - Issue 1038453002: Add option to export tracing events to ETW.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/trace_event/etw_manifest/BUILD/message_compiler.py

Issue 1038453002: Add option to export tracing events to ETW. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add missing dependency in base.gyp Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright 2015 The Chromium Authors. All rights reserved.	1 # Copyright 2015 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 # Runs the Microsoft Message Compiler (mc.exe). This Python adapter is for the	5 # Runs the Microsoft Message Compiler (mc.exe). This Python adapter is for the

6 # GYP build, which can only run Python and not native binaries.	6 # GYP build, which can only run Python and not native binaries.
	Lei Zhang 2015/04/15 08:10:35 message_compiler.py is only being referenced from message_compiler.py is only being referenced from base/trace_event/etw_manifest/BUILD.gn, and base/trace_event/etw_manifest/etw_manifest.gyp calls mc.exe directly. Did the original script you copied from mean to say GN? Georges Khalil 2015/04/15 15:10:32 Fixed. This is the same script as remoting/tools/ Show quoted text On 2015/04/15 08:10:35, Lei Zhang (slow to respond) wrote: > message_compiler.py is only being referenced from > base/trace_event/etw_manifest/BUILD.gn, and > base/trace_event/etw_manifest/etw_manifest.gyp calls mc.exe directly. Did the > original script you copied from mean to say GN? Fixed. This is the same script as remoting/tools/build/message_compiler.py which has the same error.
7	7

8 import subprocess	8 import subprocess

9 import sys	9 import sys

10	10

11 # mc writes to stderr, so this explicily redirects to stdout and eats it.	11 # mc writes to stderr, so this explicily redirects to stdout and eats it.

12 try:	12 try:

13 subprocess.check_output(["mc.exe"] + sys.argv[1:], stderr=subprocess.STDOUT)	13 subprocess.check_output(["mc.exe"] + sys.argv[1:], stderr=subprocess.STDOUT)

14 except subprocess.CalledProcessError as e:	14 except subprocess.CalledProcessError as e:

15 print e.output	15 print e.output

16 sys.exit(e.returncode)	16 sys.exit(e.returncode)

OLD	NEW