Chromium Code Reviews

Issue 10384159: Stop traversing hidden (dot) directories when searching for Dart files (Closed)

Created:
8 years, 7 months ago by Brian Wilkerson
Modified:
8 years, 7 months ago
Reviewers:
pquitslund
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Stop traversing hidden (dot) directories when searching for Dart files. I don't know that this is the only place that needs to be changed, but I know it's one place. Committed: https://code.google.com/p/dart/source/detail?r=7621

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+9 lines, -7 lines)
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/DartProjectImpl.java View 4 chunks +9 lines, -7 lines 0 comments

Messages

Total messages: 4 (0 generated)
Brian Wilkerson
8 years, 7 months ago (2012-05-14 18:53:52 UTC) #1
pquitslund
LGTM. (Aside: the whitespace churn surprises me a little since I thought we had standardized ...
8 years, 7 months ago (2012-05-14 19:24:47 UTC) #2
Brian Wilkerson
> (Aside: the whitespace churn surprises me a little since I thought we had > ...
8 years, 7 months ago (2012-05-14 19:35:22 UTC) #3
pquitslund
8 years, 7 months ago (2012-05-14 19:36:39 UTC) #4
On 2012/05/14 19:35:22, Brian Wilkerson wrote:
> > (Aside: the whitespace churn surprises me a little since I thought we had
> > standardized and applied new settings...
> 
> Sorry about that. We did, and I don't know why that happened. (I didn't even
> notice it until you pointed it out.) I'll keep an eye out for future churn.

No prob.  Thanks!

Powered by Google App Engine