Chromium Code Reviews| Index: components/BUILD.gn |
| diff --git a/components/BUILD.gn b/components/BUILD.gn |
| index 88c872a8743b3b5bde510868e147eea024abe4b9..9d946fc60946cb0dcf2154f0a555e2200dc82b20 100644 |
| --- a/components/BUILD.gn |
| +++ b/components/BUILD.gn |
| @@ -307,61 +307,67 @@ repack("components_tests_pak") { |
| ] |
| } |
| -if (is_linux && !is_chromeos) { |
| - # TODO(GYP): Figure out which of these work and are needed on other platforms. |
| +test("components_browsertests") { |
|
Dirk Pranke
2015/03/27 03:12:35
I did not follow the pattern you set w/ components
|
| + sources = [ |
| + "autofill/content/browser/risk/fingerprint_browsertest.cc", |
| + "autofill/content/renderer/password_form_conversion_utils_browsertest.cc", |
| + "dom_distiller/content/distiller_page_web_contents_browsertest.cc", |
| + "password_manager/content/renderer/credential_manager_client_browsertest.cc", |
| + ] |
| - # TODO(GYP): Finish me ... |
| - # test("components_browsertests") { |
| - # sources = [ |
| - # "autofill/content/browser/risk/fingerprint_browsertest.cc", |
| - # "autofill/content/renderer/password_form_conversion_utils_browsertest.cc", |
| - # "dom_distiller/content/distiller_page_web_contents_browsertest.cc", |
| - # "password_manager/content/renderer/credential_manager_client_browsertest.cc", |
| - # ] |
| - # |
| - # defines = [ "HAS_OUT_OF_PROC_TEST_RUNNER" ] |
| - # |
| - # deps = [ |
| - # "//components/resources:components_resources", |
| - # "//components/strings", |
| - # "//components/autofill/content/browser", |
| - # "//components/autofill/content/renderer", |
| - # "//components/dom_distiller/content", |
| - # "//components/dom_distiller/core", |
| - # "//components/password_manager/content/renderer", |
| - # "//testing/gmock", |
| - # "//testing/gtest", |
| - # "//content/public/common", |
| - # "//content/public/renderer", |
| - # ] |
| - # |
| - # if (is_android) { |
| - # sources -= [ |
| - # ] |
| - # } |
| - # if (is_linux) { |
| - # # content_extractor_browsertest is a standalone content extraction tool built as |
| - # # a MANUAL component_browsertest. |
| - # sources += [ |
| - # "dom_distiller/standalone/content_extractor_browsertest.cc", |
| - # ] |
| - # } |
| - # } |
| + defines = [ "HAS_OUT_OF_PROC_TEST_RUNNER" ] |
| - test("components_perftests") { |
| - sources = [ |
| - "visitedlink/test/visitedlink_perftest.cc", |
| - ] |
| + deps = [ |
| + "autofill/content/browser", |
| + "autofill/content/renderer", |
| + "content_settings/core/common", |
| + "dom_distiller/content", |
| + "dom_distiller/core", |
| + "dom_distiller/core:test_support", |
| + "password_manager/content/browser", |
| + "password_manager/content/common", |
| + "password_manager/content/renderer", |
| + "strings", |
| + "//base", |
| + "//base/test:test_support", |
| + "//content/test:browsertest_support", |
| + "//content/test:test_support", |
| - # TODO(jschuh): crbug.com/167187 fix size_t to int truncations. |
| - configs += [ "//build/config/compiler:no_size_t_to_int_warning" ] |
| + "//testing/gmock", |
| + "//testing/gtest", |
| + "//ui/base", |
| + ] |
| + |
| + data_deps = [ ":components_tests_pak" ] |
| + |
| + if (is_android) { |
| + sources -= [ "autofill/content/browser/risk/fingerprint_browsertest.cc" ] |
| + } |
| - deps = [ |
| - "//base", |
| - "//base/test:test_support_perf", |
| - "//testing/gtest", |
| - "//content/test:test_support", |
| - "//components/visitedlink/browser", |
| + if (is_linux) { |
| + # content_extractor_browsertest is a standalone content extraction tool built as |
| + # a MANUAL component_browsertest. |
| + sources += [ "dom_distiller/standalone/content_extractor_browsertest.cc" ] |
| + deps += [ |
| + "pref_registry:test_support", |
| + "//base:prefs_test_support", |
| ] |
| } |
| } |
| + |
| +test("components_perftests") { |
| + sources = [ |
| + "visitedlink/test/visitedlink_perftest.cc", |
| + ] |
| + |
| + # TODO(jschuh): crbug.com/167187 fix size_t to int truncations. |
| + configs += [ "//build/config/compiler:no_size_t_to_int_warning" ] |
| + |
| + deps = [ |
| + "//base", |
| + "//base/test:test_support_perf", |
| + "//testing/gtest", |
| + "//content/test:test_support", |
| + "//components/visitedlink/browser", |
| + ] |
| +} |