Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 1038323002: Implement components_browsertests in the GN build. (Closed)

Created:
5 years, 9 months ago by Dirk Pranke
Modified:
5 years, 8 months ago
Reviewers:
brettw, jam
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@clean_up_gyp_remaining
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement components_browsertests in the GN build. R=brettw@chromium.org, jam@chromium.org BUG=461019 CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg Committed: https://crrev.com/f6ca89c5fde0ed7d22b8264a51c850a4073c22ae Cr-Commit-Position: refs/heads/master@{#322890}

Patch Set 1 #

Total comments: 1

Patch Set 2 : merge to #322696 #

Patch Set 3 : do not build components_browsertests on mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -53 lines) Patch
M BUILD.gn View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M build/gn_migration.gypi View 2 chunks +1 line, -2 lines 0 comments Download
M components/BUILD.gn View 1 chunk +57 lines, -51 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
Dirk Pranke
This patch depends on https://codereview.chromium.org/1040543002/ (just for the cleanup in gn_all and gyp_remaining).
5 years, 9 months ago (2015-03-27 03:11:57 UTC) #1
Dirk Pranke
https://codereview.chromium.org/1038323002/diff/1/components/BUILD.gn File components/BUILD.gn (right): https://codereview.chromium.org/1038323002/diff/1/components/BUILD.gn#newcode310 components/BUILD.gn:310: test("components_browsertests") { I did not follow the pattern you ...
5 years, 9 months ago (2015-03-27 03:12:35 UTC) #2
jam
lgtm
5 years, 9 months ago (2015-03-27 20:38:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1038323002/1
5 years, 9 months ago (2015-03-28 01:34:11 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/9522) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 9 months ago (2015-03-28 01:36:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1038323002/20001
5 years, 9 months ago (2015-03-28 03:05:14 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/2772)
5 years, 9 months ago (2015-03-28 03:25:55 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1038323002/40001
5 years, 8 months ago (2015-03-30 20:35:01 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-03-30 22:01:51 UTC) #17
commit-bot: I haz the power
5 years, 8 months ago (2015-03-30 22:02:32 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f6ca89c5fde0ed7d22b8264a51c850a4073c22ae
Cr-Commit-Position: refs/heads/master@{#322890}

Powered by Google App Engine
This is Rietveld 408576698