fix special index parsing

fix special index parsing

R=verwaest@chromium.org,dslomov@chromium.org

BUG=

Committed: https://crrev.com/97981d94130531dd4c7d74a6efbf34f68f253da0
Cr-Commit-Position: refs/heads/master@{#27518}

[dcarney, 2015-03-27 13:01:25]

dcarney@chromium.org changed reviewers:
+ verwaest@chromium.org

[dcarney, 2015-03-27 13:30:15]

dcarney@chromium.org changed reviewers:
+ dslomov@chromium.org

[dcarney, 2015-03-27 13:31:20]

On 2015/03/27 13:30:15, dcarney wrote:
> mailto:dcarney@chromium.org changed reviewers:
> + mailto:dslomov@chromium.org

dmitry, is this correct?  Do i need to match Infinity and -Infinity as well.  As
the patch stands, -Infinity will be matched but not Infinity, and I need to
update it accordingly.

[Toon Verwaest, 2015-03-27 14:30:52]

https://codereview.chromium.org/1038313004/diff/20001/src/conversions.cc
File src/conversions.cc (right):

https://codereview.chromium.org/1038313004/diff/20001/src/conversions.cc#newc...
src/conversions.cc:521: if (buffer[offset] == '0') return offset == length - 1;
(-)0.XXX...

[dcarney, 2015-03-27 14:54:55]

On 2015/03/27 14:30:52, Toon Verwaest wrote:
> https://codereview.chromium.org/1038313004/diff/20001/src/conversions.cc
> File src/conversions.cc (right):
> 
>
https://codereview.chromium.org/1038313004/diff/20001/src/conversions.cc#newc...
> src/conversions.cc:521: if (buffer[offset] == '0') return offset == length -
1;
> (-)0.XXX...

fixed, also added Infinity/-Infinity handled for now.

[Toon Verwaest, 2015-03-30 08:52:10]

Given that you add Infinity / -Infinity I suppose we'll have to support NaN as
well. Whereas NaN !== NaN, "NaN" === "NaN", and the comparison happens on the
string level, not the double level, afaict. @dslomov: what do you think?
Other than that, lgtm

[Dmitry Lomov (no reviews), 2015-03-30 10:11:14]

On 2015/03/30 08:52:10, Toon Verwaest wrote:
> Given that you add Infinity / -Infinity I suppose we'll have to support NaN as
> well. Whereas NaN !== NaN, "NaN" === "NaN", and the comparison happens on the
> string level, not the double level, afaict. @dslomov: what do you think?
> Other than that, lgtm

7.1.6 tells us that string CanonicalNumericIndexString("NaN") is "NaN": 
  - ToNumber("NaN") is NaN
  - ToString(NaN) is "NaN"

[dcarney, 2015-03-30 10:36:35]

The CQ bit was checked by dcarney@chromium.org

[dcarney, 2015-03-30 10:36:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
verwaest@chromium.org
Link to the patchset: https://codereview.chromium.org/1038313004/#ps60001
(title: "NaN === NaN")

[commit-bot: I haz the power, 2015-03-30 10:36:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1038313004/60001

[commit-bot: I haz the power, 2015-03-30 10:56:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-30 10:56:19]

Try jobs failed on following builders:
  v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/build...)

[dcarney, 2015-03-30 11:02:22]

The CQ bit was checked by dcarney@chromium.org

[dcarney, 2015-03-30 11:02:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
verwaest@chromium.org
Link to the patchset: https://codereview.chromium.org/1038313004/#ps80001
(title: "NaN test")

[commit-bot: I haz the power, 2015-03-30 11:02:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1038313004/80001

[commit-bot: I haz the power, 2015-03-30 11:41:01]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-03-30 11:41:24]

Patchset 5 (id:??) landed as
https://crrev.com/97981d94130531dd4c7d74a6efbf34f68f253da0
Cr-Commit-Position: refs/heads/master@{#27518}