Issue 1038293002: Move test for incoming packets with incorrect connection ID from

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1038293002: Move test for incoming packets with incorrect connection ID from (Closed)

Created:
5 years, 9 months ago by ramant (doing other things)

Modified:
5 years, 9 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@Fix_flaky_QUIC_end_to_end_test_89220759

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Move test for incoming packets with incorrect connection ID from QuicConnection::OnPacketHeader to ::OnUnauthenticatedPublicHeader so it works. Add tests to verify code handles incoming packets with invalid connection IDs. Add DCHECKs to verify that QuicConnection::OnPublicResetPacket and ::OnVersionNegotiationPacket don't get packets with invalid connection IDs. Add comment to QuicConnection::ProcessUdpPacket to note packet may have incorrect connection ID. Fix b/19710533. Merge internal change: 89336249 R=rch@chromium.org

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+168 lines, -62 lines)			Patch
M	net/quic/quic_connection.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	net/quic/quic_connection.cc	View	4 chunks	+27 lines, -12 lines	0 comments	Download
M	net/quic/quic_connection_test.cc	View	1 chunk	+0 lines, -50 lines	0 comments	Download
M	net/quic/test_tools/quic_test_utils.h	View	1 chunk	+45 lines, -0 lines	0 comments	Download
M	net/quic/test_tools/quic_test_utils.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	net/tools/quic/end_to_end_test.cc	View	2 chunks	+88 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages