Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 1038243002: gles2_conform_test (Closed)

Created:
5 years, 9 months ago by tfarina
Modified:
5 years, 9 months ago
Reviewers:
Dirk Pranke, no sievers
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu: Add gles2_conform_test target to GN build. The internal stuff will come later. Tested on Linux with the following command lines: $ gn gen out-gn $ ninja -C out-gn gles2_conform_test BUG=432959 TEST=see above R=dpranke@chromium.org,sievers@chromium.org Committed: https://crrev.com/9973bb235a2e9d5ba33d341a77006e3d92f764f0 Cr-Commit-Position: refs/heads/master@{#322573}

Patch Set 1 #

Patch Set 2 : add missing dependency #

Total comments: 5

Patch Set 3 : self review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M gpu/config/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M gpu/gles2_conform_support/BUILD.gn View 1 2 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
tfarina
PTAL! https://codereview.chromium.org/1038243002/diff/20001/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/1038243002/diff/20001/BUILD.gn#newcode58 BUILD.gn:58: "//gpu/gles2_conform_support:gles2_conform_test", just added this here for testing, I ...
5 years, 9 months ago (2015-03-27 00:11:38 UTC) #1
Dirk Pranke
lgtm
5 years, 9 months ago (2015-03-27 00:33:29 UTC) #2
no sievers
lgtm https://codereview.chromium.org/1038243002/diff/20001/gpu/config/BUILD.gn File gpu/config/BUILD.gn (right): https://codereview.chromium.org/1038243002/diff/20001/gpu/config/BUILD.gn#newcode55 gpu/config/BUILD.gn:55: "//gpu/command_buffer/service", On 2015/03/27 00:11:38, tfarina wrote: > it ...
5 years, 9 months ago (2015-03-27 00:57:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1038243002/40001
5 years, 9 months ago (2015-03-27 13:51:10 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-27 14:12:24 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-27 14:13:08 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9973bb235a2e9d5ba33d341a77006e3d92f764f0
Cr-Commit-Position: refs/heads/master@{#322573}

Powered by Google App Engine
This is Rietveld 408576698