tools/gn/parser.cc - Issue 1038233002: tools/gn: disallow non-canonical integer literals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/parser.cc

Issue 1038233002: tools/gn: disallow non-canonical integer literals (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move kBad tests down by usage Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/parser.cc

diff --git a/tools/gn/parser.cc b/tools/gn/parser.cc

index 1fa432e3a8061704d7cac1ea900948327140f582..05aab74227bcb8b6aeecc5113e5f698f6806885b 100644

--- a/tools/gn/parser.cc

+++ b/tools/gn/parser.cc

@@ -49,6 +49,8 @@ const char kGrammar_Help[] =

"\n"

" integer = [ \"-\" ] digit { digit } .\n"

"\n"

+ " Leading zeros and negative zero are disallowed.\n"

+ "\n"

"String literals\n"

"\n"

" A string literal represents a string value consisting of the quoted\n"

« no previous file with comments | « tools/gn/parse_tree_unittest.cc ('k') | no next file » | no next file with comments »