tools/gn: disallow non-canonical integer literals

tools/gn/parse_tree_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "testing/gtest/include/gtest/gtest.h"
 #include "tools/gn/input_file.h"
 #include "tools/gn/parse_tree.h"
 #include "tools/gn/scope.h"
 #include "tools/gn/test_with_scope.h"
 
@@ skipping 194 matching lines @@
         input.parsed()->AsBlock()->statements()[0]->AsBinaryOp();
     ASSERT_TRUE(binop->right()->AsList());
     const ListNode* list = binop->right()->AsList();
     EXPECT_EQ(3u, list->contents().size());
     auto ranges = list->GetSortRanges();
     ASSERT_EQ(1u, ranges.size());
     EXPECT_EQ(1u, ranges[0].begin);
     EXPECT_EQ(3u, ranges[0].end);
   }
 }
+
+TEST(ParseTree, Integers) {
+  const char *good[] = {
+    "0",
+    "10",
+    "-54321",
+    "9223372036854775807",
+    "-9223372036854775808",
+  };
+
+  const char *bad[] = {

[brettw, 2015/03/31 23:05:33]

I think it would be better to move this to right above the loop (style guide
says to keep var declarations as close as possible to use).

[mdempsky, 2015/03/31 23:19:20]

Done.

+    "-0",
+    "010",
+    "-010",
+    "9223372036854775808",
+    "-9223372036854775809",
+  };
+
+  for (auto s : good) {
+    TestParseInput input(std::string("x = ") + s);
+    EXPECT_FALSE(input.has_error());
+
+    TestWithScope setup;
+    Err err;
+    input.parsed()->Execute(setup.scope(), &err);
+    EXPECT_FALSE(err.has_error());
+  }
+
+  for (auto s : bad) {
+    TestParseInput input(std::string("x = ") + s);
+    EXPECT_FALSE(input.has_error());
+
+    TestWithScope setup;
+    Err err;
+    input.parsed()->Execute(setup.scope(), &err);
+    EXPECT_TRUE(err.has_error());
+  }
+}