Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Unified Diff: Source/platform/text/BidiResolver.h

Issue 103823005: Isolated elements at end of line are not being correctly treated (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/rendering/InlineIterator.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/text/BidiResolver.h
diff --git a/Source/platform/text/BidiResolver.h b/Source/platform/text/BidiResolver.h
index 64c7bb1f4c9a007898b44445523619111818df41..fab8f751379633b5ef9a3d3c140cefee6cd34ed4 100644
--- a/Source/platform/text/BidiResolver.h
+++ b/Source/platform/text/BidiResolver.h
@@ -234,6 +234,8 @@ public:
void setMidpointStateForIsolatedRun(Run*, const MidpointState<Iterator>&);
MidpointState<Iterator> midpointStateForIsolatedRun(Run*);
+ Iterator endOfLine() const { return m_endOfLine; }
+
protected:
void increment() { m_current.increment(); }
// FIXME: Instead of InlineBidiResolvers subclassing this method, we should
@@ -588,6 +590,8 @@ void BidiResolver<Iterator, Run>::createBidiRunsForLine(const Iterator& end, Vis
ASSERT(m_direction == OtherNeutral);
+ m_endOfLine = end;
+
if (override != NoVisualOverride) {
m_emptyRun = false;
m_sor = m_current;
@@ -607,7 +611,6 @@ void BidiResolver<Iterator, Run>::createBidiRunsForLine(const Iterator& end, Vis
m_emptyRun = true;
m_eor = Iterator();
- m_endOfLine = end;
m_last = m_current;
bool lastLineEnded = false;
« no previous file with comments | « Source/core/rendering/InlineIterator.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698