Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 103823005: Isolated elements at end of line are not being correctly treated (Closed)

Created:
7 years ago by igoroliveira
Modified:
7 years ago
CC:
blink-reviews, bemjb+rendering_chromium.org, zoltan1, eae+blinkwatch, leviw+bidiwatch_chromium.org, leviw+renderwatch, jchaffraix+rendering
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

When "end of line" is an isolated element, InlineIterator::increment is wrongly moving the iterator to the next object. This patch fixes the behavior verifying if endOfLine is the current isolated object or a child of it. Now the worst case scenario for Inline::increment happens when endOfLine is the isolated element. BUG=326860 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164123

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -2 lines) Patch
A LayoutTests/fast/text/output-isolate-at-end-of-line-crash.html View 1 chunk +26 lines, -0 lines 0 comments Download
A LayoutTests/fast/text/output-isolate-at-end-of-line-crash-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/rendering/InlineIterator.h View 1 chunk +17 lines, -1 line 0 comments Download
M Source/platform/text/BidiResolver.h View 3 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
igoroliveira
7 years ago (2013-12-10 23:19:11 UTC) #1
igoroliveira
On 2013/12/10 23:19:11, igoroliveira wrote: Sadly the code increases the complexity of InlineIterator::increment, i am ...
7 years ago (2013-12-10 23:20:28 UTC) #2
igoroliveira
7 years ago (2013-12-10 23:20:47 UTC) #3
eseidel
Levi is probably your best reviewer, but I believe he's on vacation this week.
7 years ago (2013-12-10 23:31:53 UTC) #4
eseidel
lgtm
7 years ago (2013-12-18 21:03:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/igor.o@sisa.samsung.com/103823005/1
7 years ago (2013-12-18 21:04:10 UTC) #6
commit-bot: I haz the power
7 years ago (2013-12-18 22:28:48 UTC) #7
Message was sent while issue was closed.
Change committed as 164123

Powered by Google App Engine
This is Rietveld 408576698