Source/web/tests/data/touch-action-simple.html - Issue 103823003: Implement touch-action pan-x/pan-y handling on the main thread

Side by Side Diff: Source/web/tests/data/touch-action-simple.html

Issue 103823003: Implement touch-action pan-x/pan-y handling on the main thread (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@issue1

Patch Set: removed unrelated file Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/web/tests/data/touch-action-overflow.html ('K') | « Source/web/tests/data/touch-action-overflow.html ('k') | Source/web/tests/data/touch-action-tests.css » ('j') | Source/web/tests/data/touch-action-tests.css » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <link rel='stylesheet' type='text/css' href='touch-action-tests.css'>	2 <link rel='stylesheet' type='text/css' href='touch-action-tests.css'>

3 <script src='touch-action-tests.js'></script>	3 <script src='touch-action-tests.js'></script>

4	4

5 <!--	5 <!--

6 Test a bunch of simple cases where touch-action: none results in a non-fast -scrollable region.	6 Test a bunch of simple cases where touch-action: none results in a non-fast -scrollable region.

7 -->	7 -->

8	8

9 <div expected-action='auto'>Simple div with no explicit touch-action</div>	9 <div expected-action='auto'>Simple div with no explicit touch-action</div>

10 <div class='ta-none' expected-action='none'>Simple div with touch-action: none</ div>	10 <div class='ta-none' expected-action='none'>Simple div with touch-action: none</ div>

	11 <div class='ta-panx' expected-action='pan-x'>Simple div with touch-action: pan-x </div>
	Rick Byers 2013/12/12 20:47:24 Please add a separate test case / input file for t Please add a separate test case / input file for the pan cases. These are no longer really "simple" and breaking it up makes it easier to prioritize and debug failures. I don't have a strong opinion about the overflow scroll cases - they could either stay in the scroll test case or move to the pan test case. gnana 2013/12/13 16:52:53 Done. Show quoted text On 2013/12/12 20:47:24, Rick Byers wrote: > Please add a separate test case / input file for the pan cases. These are no > longer really "simple" and breaking it up makes it easier to prioritize and > debug failures. > > I don't have a strong opinion about the overflow scroll cases - they could > either stay in the scroll test case or move to the pan test case. Done.
	12 <div class='ta-pany' expected-action='pan-y'>Simple div with touch-action: pan-y </div>

	13 <div class='ta-panxy' expected-action='pan-x pan-y'>Simple div with touch-action : pan-x pan-y</div>

11	14

12 <div class='ta-none' style='height: 0; margin-bottom: 50px'>	15 <div class='ta-none' style='height: 0; margin-bottom: 50px'>

13 <div expected-action='none'>	16 <div expected-action='none'>

14 Touch-action: none is propagated to descendants	17 Touch-action: none is propagated to descendants

15 </div>	18 </div>

16 </div>	19 </div>

17	20

18 <div class='ta-none' style='height: 0; margin-bottom: 50px'>	21 <div class='ta-none' style='height: 0; margin-bottom: 50px'>

19 <div class='ta-auto' expected-action='none'>	22 <div class='ta-auto' expected-action='none'>

20 Explicitly setting touch-action: auto does nothing to prevent propagation of none	23 Explicitly setting touch-action: auto does nothing to prevent propagation of none

21 </div>	24 </div>

22 </div>	25 </div>

23	26

	27 <div class='ta-none' style='height: 0; margin-bottom: 50px'>

	28 <div class='ta-panx' expected-action='none'>

	29 Explicitly setting touch-action: pan-x does nothing to prevent propagation o f none

	30 </div>

	31 </div>

	32

	33 <div class='ta-none' style='height: 0; margin-bottom: 50px'>

	34 <div class='ta-pany' expected-action='none'>

	35 Explicitly setting touch-action: pan-y does nothing to prevent propagation o f none
	Rick Byers 2013/12/12 20:47:24 It's probably overkill to list each possible combi It's probably overkill to list each possible combination here, but we should try to hit some of the key different branches in the code (most of which aren't covered here). So I'd suggest maybe: - outer=ta-none, inner=ta-panx (as you have above) - outer=ta-pany, inner=none - outer=ta-panx, inner=ta-pany (as you have below) - outer=ta-panxy, inner=ta-auto - outer=ta-panx, inner=ta-panxy - outer=ta-panxy, inner=ta-pany - maybe one 3-level case, like outer=ta-panx middle=ta-auto inner=ta-pany gnana 2013/12/13 16:52:53 Done. Show quoted text On 2013/12/12 20:47:24, Rick Byers wrote: > It's probably overkill to list each possible combination here, but we should try > to hit some of the key different branches in the code (most of which aren't > covered here). So I'd suggest maybe: > - outer=ta-none, inner=ta-panx (as you have above) > - outer=ta-pany, inner=none > - outer=ta-panx, inner=ta-pany (as you have below) > - outer=ta-panxy, inner=ta-auto > - outer=ta-panx, inner=ta-panxy > - outer=ta-panxy, inner=ta-pany > - maybe one 3-level case, like outer=ta-panx middle=ta-auto inner=ta-pany Done.
	36 </div>

	37 </div>

	38

	39 <div class='ta-none' style='height: 0; margin-bottom: 50px'>

	40 <div class='ta-panxy' expected-action='none'>

	41 Explicitly setting touch-action: pan-x pan-y does nothing to prevent propaga tion of none

	42 </div>

	43 </div>

	44

	45 <div class='ta-panx' style='height: 0; margin-bottom: 50px'>
	Rick Byers 2013/12/12 20:47:24 You don't need the 'height:- margin-bottom: 50px' You don't need the 'height:- margin-bottom: 50px' hack in this case. The point of that hack is to ensure that a hit-testing bug that picked up the outer element instead of the inner one wouldn't produce the same result as what we expect. In this case (and many of the other ones I suggested above) the expected action is different from that of the outer div, so they can just have a normal containment relationship without risking any such bug. gnana 2013/12/13 16:52:53 Done. Show quoted text On 2013/12/12 20:47:24, Rick Byers wrote: > You don't need the 'height:- margin-bottom: 50px' hack in this case. The point > of that hack is to ensure that a hit-testing bug that picked up the outer > element instead of the inner one wouldn't produce the same result as what we > expect. In this case (and many of the other ones I suggested above) the > expected action is different from that of the outer div, so they can just have a > normal containment relationship without risking any such bug. Done.
	46 <div class='ta-pany' expected-action='none'>

	47 Explicitly setting touch-action: pan-y does nothing to prevent propagation o f pan-x resulting to none
	Rick Byers 2013/12/12 20:47:24 I don't think the 'prevent propagation of...' part I don't think the 'prevent propagation of...' part of the description still applies to this case. I'd simplify the description of this test to something like "Disjoint flags intersect to none". gnana 2013/12/13 16:52:53 Done. Show quoted text On 2013/12/12 20:47:24, Rick Byers wrote: > I don't think the 'prevent propagation of...' part of the description still > applies to this case. I'd simplify the description of this test to something > like "Disjoint flags intersect to none". Done.
	48 </div>

	49 </div>

	50

	51 <div class='ta-pany' style='height: 0; margin-bottom: 50px'>

	52 <div class='ta-panx' expected-action='none'>

	53 Explicitly setting touch-action: pan-x does nothing to prevent propagation o f pan-y resulting to none

	54 </div>

	55 </div>

	56

	57 <div class='ta-panx' style='height: 0; margin-bottom: 50px'>

	58 <div class='ta-panxy' expected-action='pan-x'>

	59 Explicitly setting touch-action: pan-x pan-y does nothing to prevent propaga tion of pan-x

	60 </div>

	61 </div>

	62

	63 <div class='ta-pany' style='height: 0; margin-bottom: 50px'>

	64 <div class='ta-panxy' expected-action='pan-y'>

	65 Explicitly setting touch-action: pan-x pan-y does nothing to prevent propaga tion of pan-y

	66 </div>

	67 </div>

	68

24 <div style='padding: 20px 0'>	69 <div style='padding: 20px 0'>

25 <span class='ta-none' expected-action='auto'>Touch-action should be ignored on inline elements	70 <span class='ta-none' expected-action='auto'>Touch-action should be ignored on inline elements

26 <div expected-action='auto'>And not propagated to any block children</div>	71 <div expected-action='auto'>And not propagated to any block children</div>

27 </span>	72 </span>

28 </div>	73 </div>

29 <p>Below case is broken, should be AUTO - <a href='http://crbug.com/319479'>Bug 319479</a></p>	74 <p>Below case is broken, should be AUTO - <a href='http://crbug.com/319479'>Bug 319479</a></p>

30 <div class='ta-none' style='height: 0; margin-bottom: 100px'>	75 <div class='ta-none' style='height: 0; margin-bottom: 100px'>

31 <span expected-action='none'>	76 <span expected-action='none'>

32 touch-action should not be inherited by inline elements	77 touch-action should not be inherited by inline elements

33 <div expected-action='none'>But is inherited by any block descendants of the m</div>	78 <div expected-action='none'>But is inherited by any block descendants of the m</div>

34 </span>	79 </span>

35 </div>	80 </div>

OLD	NEW