Source/web/tests/data/touch-action-overflow.html - Issue 103823003: Implement touch-action pan-x/pan-y handling on the main thread

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/web/tests/data/touch-action-overflow.html

Issue 103823003: Implement touch-action pan-x/pan-y handling on the main thread (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@issue1

Patch Set: removed unrelated file Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <link rel='stylesheet' type='text/css' href='touch-action-tests.css'>	2 <link rel='stylesheet' type='text/css' href='touch-action-tests.css'>

3 <script src='touch-action-tests.js'></script>	3 <script src='touch-action-tests.js'></script>

4	4

5 <!--	5 <!--

6 Test a bunch of cases involving overflow: scroll elements.	6 Test a bunch of cases involving overflow: scroll elements.

7 -->	7 -->

8 <div class='scroll' style='height:75px'>	8 <div class='scroll' style='height:75px'>

9 <div class='ta-none' expected-action="none">	9 <div class='ta-none' expected-action="none">

10 touch-action: none still applies in scrollable area	10 touch-action: none still applies in scrollable area

11 </div>	11 </div>

12 <div class='spacer'></div>	12 <div class='spacer'></div>

13 </div>	13 </div>

14	14

15 <div class='ta-none scroll' style='height:75px'>	15 <div class='ta-none scroll' style='height:75px'>

16 <div expected-action='none'>	16 <div expected-action='none'>

17 Touch-action inherited by child in scrollable area	17 Touch-action inherited by child in scrollable area

18 </div>	18 </div>

19 <div class='spacer'></div>	19 <div class='spacer'></div>

20 </div>	20 </div>

21	21

22 <div class='ta-none'>	22 <div class='ta-none'>

23 <div class='scroll' expected-action='auto'>	23 <div class='scroll' expected-action='auto'>

24 Touch-action: none is not propagated into overflow-scroll elements	24 Touch-action: none is not propagated into overflow-scroll elements

25 </div>	25 </div>

26 </div>	26 </div>

	27

	28 <div class='scroll ta-panx' style='height:75px'>
	Rick Byers 2013/12/12 20:47:24 These two tests really test the same code paths as These two tests really test the same code paths as tests in 'simple' (just intersecting pan-x with auto or pan-y). I think the key thing to test here is that the scroller behaves as a boundary for the pan values (not just for 'none' as tested above). So for example, have an outer div with ta-panx and a scroller with ta-pany. One case like that is probably sufficient since there really isn't distinct code paths involved here. gnana 2013/12/13 16:52:53 Done. Show quoted text On 2013/12/12 20:47:24, Rick Byers wrote: > These two tests really test the same code paths as tests in 'simple' (just > intersecting pan-x with auto or pan-y). I think the key thing to test here is > that the scroller behaves as a boundary for the pan values (not just for 'none' > as tested above). So for example, have an outer div with ta-panx and a scroller > with ta-pany. One case like that is probably sufficient since there really > isn't distinct code paths involved here. Done.
	29 <div class='ta-auto' expected-action='pan-x'>

	30 Touch-action: auto does nothing to prevent propagation of pan-x

	31 </div>

	32 </div>

	33

	34 <div class='scroll ta-panx' style='height:75px'>

	35 <div class='ta-pany' expected-action='none'>

	36 Explicitly setting touch-action: pan-y does nothing to prevent propagation o f pan-x resulting to none

	37 </div>

	38 </div>

	39

OLD	NEW