Implement touch-action pan-x/pan-y handling on the main thread

Source/core/page/EventHandler.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  * Copyright (C) 2012 Digia Plc. and/or its subsidiary(-ies)
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
@@ skipping 3961 matching lines @@
 {
     // Optimization to minimize risk of this new feature (behavior should be identical
     // since there's no way to get non-default touch-action values).
     if (!RuntimeEnabledFeatures::cssTouchActionEnabled())
         return TouchActionAuto;
 
     // Start by permitting all actions, then walk the block level elements from
     // the target node up to the nearest scrollable ancestor and exclude any
     // prohibited actions. For now this is trivial, but when we add more types
     // of actions it'll get a little more complex.
+    TouchAction effectiveTouchAction = TouchActionAuto;
     for (const Node* curNode = &node; curNode; curNode = NodeRenderingTraversal::parent(curNode)) {
         // The spec says only block and SVG elements get touch-action.
         // FIXME(rbyers): Add correct support for SVG, crbug.com/247396.
         if (RenderObject* renderer = curNode->renderer()) {
             if (renderer->isRenderBlockFlow()) {
-                if (renderer->style()->touchAction() == TouchActionNone)
-                    return TouchActionNone;
+                TouchAction action = renderer->style()->touchAction();
+                if (action == TouchActionNone) {
+                    effectiveTouchAction = action;

[Rick Byers, 2013/12/12 20:47:24]

As esprehn pointed out reviewing my CL for this, we should immediately return
whenever effectiveTouchAction becomes None.  Perhaps just add a test and 'break'
for this at the bottom.

[gnana, 2013/12/13 16:52:53]

Done.

+                } else if (action == TouchActionPanX) {

[Rick Byers, 2013/12/12 20:47:24]

This seems correct, but it's pretty verbose and hard to scale as we add more
flags.   I think this could be simplified and made more general by writing a
helper function like:

TouchAction intersectTouchAction(TouchAction ta1, TouchAction ta2)
{
  if (ta1 == None || ta2 == None)
    return None;
  if (ta1 == Auto)
    return ta2;
  if (ta2 == Auto)
    return ta1;
  if (!(ta1 & ta2))
    return None;
  return ta1 & ta2;
}

This logic could be slightly simpler if we renumbered None to be 0 and Auto to
be 1 (instead of the other way around as it is currently), but I don't think it
really matters (and having the default be value 0 is kind of nice).

[gnana, 2013/12/13 16:52:53]

Done.

+                    if (effectiveTouchAction == TouchActionPanY) {
+                        effectiveTouchAction = TouchActionNone;
+                    } else if (effectiveTouchAction == TouchActionAuto || effectiveTouchAction == (TouchActionPanX | TouchActionPanY)) {
+                        effectiveTouchAction = TouchActionPanX;
+                    }
+                } else if (action == TouchActionPanY) {
+                    if (effectiveTouchAction == TouchActionPanX) {
+                        effectiveTouchAction = TouchActionNone;
+                    } else if (effectiveTouchAction == TouchActionAuto || effectiveTouchAction == (TouchActionPanX | TouchActionPanY)) {
+                        effectiveTouchAction = TouchActionPanY;
+                    }
+                } else if (action == (TouchActionPanX | TouchActionPanY)) {
+                    if (effectiveTouchAction == TouchActionPanX)
+                        effectiveTouchAction = TouchActionPanX;
+                    else if (effectiveTouchAction == TouchActionPanY)
+                        effectiveTouchAction = TouchActionPanY;
+                    else if (effectiveTouchAction == TouchActionAuto)
+                        effectiveTouchAction = TouchActionPanX | TouchActionPanY;
+                }
             }
 
             // If we've reached an ancestor that supports a touch action, search no further.
             if (renderer->isBox() && toRenderBox(renderer)->scrollsOverflow())
                 break;
         }
     }
-    return TouchActionAuto;
+    return effectiveTouchAction;
 }
 
 void EventHandler::setLastKnownMousePosition(const PlatformMouseEvent& event)
 {
     m_mousePositionIsUnknown = false;
     m_lastKnownMousePosition = event.position();
     m_lastKnownMouseGlobalPosition = event.globalPosition();
 }
 
 bool EventHandler::passMousePressEventToSubframe(MouseEventWithHitTestResults& mev, Frame* subframe)
@@ skipping 67 matching lines @@
 unsigned EventHandler::accessKeyModifiers()
 {
 #if OS(MACOSX)
     return PlatformEvent::CtrlKey | PlatformEvent::AltKey;
 #else
     return PlatformEvent::AltKey;
 #endif
 }
 
 } // namespace WebCore