Issue 10382153: Stop scanning hidden (dot) directories when searching for Dart files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10382153: Stop scanning hidden (dot) directories when searching for Dart files (Closed)

Created:
8 years, 7 months ago by danrubel

Modified:
8 years, 7 months ago

Reviewers:
pquitslund, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Stop scanning hidden (dot) directories when searching for Dart files Committed: https://code.google.com/p/dart/source/detail?r=7630

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/ResourceChangeListener.java	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM, with one question. Do we want to automatically ignore all hidden directories? This would ...

8 years, 7 months ago (2012-05-14 19:20:37 UTC) #2

pquitslund

8 years, 7 months ago (2012-05-14 19:27:04 UTC) #3

LGTM.

On 2012/05/14 19:20:37, Brian Wilkerson wrote:
> LGTM, with one question. Do we want to automatically ignore all hidden
> directories? This would have the advantage that hidden directories would be
> marked as ignored in the UI, which might make the results less startling to
> users.

+1 (I think).  I guess I have to mull this over but my gut says this is right.

Expand Messages | Collapse Messages