Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 1038213002: Add grit resource ID file to GN grit script inputs. (Closed)

Created:
5 years, 9 months ago by brettw
Modified:
5 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add grit resource ID file to GN grit script inputs. Grit's execution depends on the resource ID file, but this was not listed as a dependency in grit targets. This means that changing the resource ID file wouldn't re-run grit. Committed: https://crrev.com/fd9bbb762401141baa603ef5bececbc9426da169 Cr-Commit-Position: refs/heads/master@{#322531}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M build/secondary/tools/grit/grit_rule.gni View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
brettw
5 years, 9 months ago (2015-03-26 23:32:52 UTC) #2
sky
LGTM
5 years, 9 months ago (2015-03-27 01:13:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1038213002/1
5 years, 9 months ago (2015-03-27 04:49:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-27 04:53:00 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-27 04:53:33 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fd9bbb762401141baa603ef5bececbc9426da169
Cr-Commit-Position: refs/heads/master@{#322531}

Powered by Google App Engine
This is Rietveld 408576698