Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 10382121: Add Android cross-compilation support for x86 (Closed)

Created:
8 years, 7 months ago by Lijuan Xiao
Modified:
8 years, 5 months ago
Reviewers:
Yang, Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Add Android cross-compilation support for x86 TEST=make android-ia32.release Obsoleted by https://chromiumcodereview.appspot.com/10778033/.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+488 lines, -20 lines) Patch
M Makefile View 6 chunks +47 lines, -18 lines 0 comments Download
A build/android-arm.gypi View 1 chunk +225 lines, -0 lines 0 comments Download
A build/android-ia32.gypi View 1 chunk +210 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lijuan Xiao
Hi, I saw v8 already support android cross-compilation for ARM. Here I submit a patch ...
8 years, 7 months ago (2012-05-11 04:08:25 UTC) #1
Yang
Adding Jakob. I haven't had a close look at the patch yet, but please do ...
8 years, 7 months ago (2012-05-11 06:38:30 UTC) #2
Jakob Kummerow
Tabs in the Makefile are fine, as they're required by standard Makefile syntax. Please use ...
8 years, 7 months ago (2012-05-11 09:06:35 UTC) #3
Lijuan Xiao
8 years, 7 months ago (2012-05-11 09:43:13 UTC) #4
Hi, Jakob, thanks for comments.

Yes, to setup toolchain for x86, we just need add --arch=x86 when executing
make-standalone-toolchain.sh. That's the only thing to add to the wiki.

When I made the patch, I also thought of use the unified android.gypi. However I
noticed there exist armu.gypi and mipsu.gypi (missing in latest version), and
thought developers can refine android-arm.gypi and android-ia32.gypi
respectively later. If you think this way is not acceptable, I could have a look
on how to combine them when available. Your try is also appreciated. Let us keep
tuned here.

Powered by Google App Engine
This is Rietveld 408576698