Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Unified Diff: components/content_settings/core/browser/content_settings_utils.h

Issue 1038203003: Default Provider style fixes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Generalized the function. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/content_settings/core/browser/content_settings_utils.h
diff --git a/components/content_settings/core/browser/content_settings_utils.h b/components/content_settings/core/browser/content_settings_utils.h
index 03861991cc8fe855012e5ebebf714db2e7e69404..8334651ec389dd929625dd85fe0a63ce46b5a0de 100644
--- a/components/content_settings/core/browser/content_settings_utils.h
+++ b/components/content_settings/core/browser/content_settings_utils.h
@@ -59,6 +59,10 @@ base::Value* GetContentSettingValueAndPatterns(
ContentSettingsPattern* primary_pattern,
ContentSettingsPattern* secondary_pattern);
+// Returns a |base::Value*| representation of |setting| if |setting| is
+// a valid content setting. Otherwise, returns a nullptr.
+base::Value* ContentSettingToValue(ContentSetting setting);
Bernhard Bauer 2015/04/07 11:00:30 You could return a scoped_ptr here.
msramek 2015/04/08 08:50:57 Done. I agree that it's cleaner (although 3 out of
+
base::Value* GetContentSettingValueAndPatterns(
const ProviderInterface* provider,
const GURL& primary_url,

Powered by Google App Engine
This is Rietveld 408576698