Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Side by Side Diff: Source/platform/fonts/FontFallbackList.cpp

Issue 1038193002: Clear baseLayoutStyle when the font selector version has increased. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Addressed review issues Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/platform/fonts/FontFallbackList.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006 Apple Computer, Inc. All rights reserved. 2 * Copyright (C) 2006 Apple Computer, Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 226 matching lines...) Expand 10 before | Expand all | Expand 10 after
237 ASSERT(FontCache::fontCache()->generation() == m_generation); 237 ASSERT(FontCache::fontCache()->generation() == m_generation);
238 RefPtr<FontData> result = getFontData(fontDescription, m_familyIndex); 238 RefPtr<FontData> result = getFontData(fontDescription, m_familyIndex);
239 if (result) { 239 if (result) {
240 m_fontList.append(result); 240 m_fontList.append(result);
241 if (result->isLoadingFallback()) 241 if (result->isLoadingFallback())
242 m_hasLoadingFallback = true; 242 m_hasLoadingFallback = true;
243 } 243 }
244 return result.get(); 244 return result.get();
245 } 245 }
246 246
247 bool FontFallbackList::isValid() const
248 {
249 if (!m_fontSelector)
250 return m_fontSelectorVersion == 0;
251
252 return m_fontSelector->version() == m_fontSelectorVersion;
253 }
254
247 } // namespace blink 255 } // namespace blink
OLDNEW
« no previous file with comments | « Source/platform/fonts/FontFallbackList.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698