Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1038143002: favor DCHECK_CURRENTLY_ON for better logs in chromecast/ (Closed)

Created:
5 years, 9 months ago by Mostyn Bramley-Moore
Modified:
5 years, 9 months ago
Reviewers:
lcwu1, gunsch
CC:
chromium-reviews, lcwu+watch_chromium.org, yurys, feature-media-reviews_chromium.org, devtools-reviews_chromium.org, gunsch+watch_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

favor DCHECK_CURRENTLY_ON for better logs in chromecast/ BUG=466848 Committed: https://crrev.com/195191403247359aa711b5d74fecf97281182f3a Cr-Commit-Position: refs/heads/master@{#322500}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -30 lines) Patch
M chromecast/browser/cast_http_user_agent_settings.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chromecast/browser/devtools/remote_debugging_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/browser/media/cma_message_filter_host.cc View 16 chunks +23 lines, -23 lines 0 comments Download
M chromecast/browser/url_request_context_factory.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Mostyn Bramley-Moore
@Damien: please take a look.
5 years, 9 months ago (2015-03-26 22:31:41 UTC) #2
lcwu1
5 years, 9 months ago (2015-03-26 22:36:25 UTC) #4
gunsch
lgtm
5 years, 9 months ago (2015-03-26 22:37:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1038143002/1
5 years, 9 months ago (2015-03-26 23:30:07 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-27 00:00:23 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-27 00:00:59 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/195191403247359aa711b5d74fecf97281182f3a
Cr-Commit-Position: refs/heads/master@{#322500}

Powered by Google App Engine
This is Rietveld 408576698