Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 1038133003: Fix crash in taking a screenshot of a closed popup (Closed)

Created:
5 years, 9 months ago by enne (OOO)
Modified:
5 years, 9 months ago
Reviewers:
piman
CC:
chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash in taking a screenshot of a closed popup You can't assume that there's a root layer always during layout, even if there's a composite and readback. WebTestProxyBase::CapturePixelsAsync iterates through popups (which may get closed between that call and Layout). If it's closed, then its root layer goes away. BUG=470817 Committed: https://crrev.com/cf337a958289161fa9106a51ff5acd19468bcda3 Cr-Commit-Position: refs/heads/master@{#322611}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add brackets; improve comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M content/renderer/gpu/render_widget_compositor.cc View 1 2 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
enne (OOO)
5 years, 9 months ago (2015-03-26 23:03:26 UTC) #2
piman
lgtm https://codereview.chromium.org/1038133003/diff/1/content/renderer/gpu/render_widget_compositor.cc File content/renderer/gpu/render_widget_compositor.cc (right): https://codereview.chromium.org/1038133003/diff/1/content/renderer/gpu/render_widget_compositor.cc#newcode808 content/renderer/gpu/render_widget_compositor.cc:808: temporary_copy_output_request_ = nullptr; nit: wrong indent, or did ...
5 years, 9 months ago (2015-03-26 23:09:58 UTC) #3
enne (OOO)
https://codereview.chromium.org/1038133003/diff/1/content/renderer/gpu/render_widget_compositor.cc File content/renderer/gpu/render_widget_compositor.cc (right): https://codereview.chromium.org/1038133003/diff/1/content/renderer/gpu/render_widget_compositor.cc#newcode808 content/renderer/gpu/render_widget_compositor.cc:808: temporary_copy_output_request_ = nullptr; On 2015/03/26 23:09:58, piman (Very slow ...
5 years, 9 months ago (2015-03-27 17:40:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1038133003/20001
5 years, 9 months ago (2015-03-27 17:42:23 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-27 18:36:28 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-27 18:38:18 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cf337a958289161fa9106a51ff5acd19468bcda3
Cr-Commit-Position: refs/heads/master@{#322611}

Powered by Google App Engine
This is Rietveld 408576698