Autofill OSX: Disable inputs and Verify button after permanent error.

chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm

 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/message_loop/message_loop.h"
 #include "base/strings/sys_string_conversions.h"
 #include "chrome/browser/ui/autofill/autofill_dialog_models.h"
 #include "chrome/browser/ui/autofill/autofill_dialog_types.h"
 #include "chrome/browser/ui/autofill/card_unmask_prompt_controller.h"
@@ skipping 181 matching lines @@
             SysUTF16ToNSString(text), kProgressFontStyle, NSCenterTextAlignment,
             NSLineBreakByWordWrapping);
     [progressOverlayLabel_ setAttributedStringValue:attributedString];
   }
 
   [progressOverlayLabel_ setHidden:text.empty()];
   [inputRowView_ setHidden:!text.empty()];
   [self updateVerifyButtonEnabled];
 }
 
+- (void)setInputsEnabled:(BOOL)enabled {

[bondd, 2015/03/26 19:50:06]

Only ever called with enabled == NO. I could rename it to -disableInputs if you
prefer.

[groby-ooo-7-16, 2015/03/26 20:17:45]

No, I'd leave it, for API symmetry. If you leave this as a separate call.

but - why not:

for (NSView view in [[self view] subviews])
  [view setEnabled:enabled];

which could be neatly inlined.

[bondd, 2015/03/26 20:33:12]

We want to leave the Cancel button enabled.

[bondd, 2015/03/26 20:46:52]

Also, unless I'm missing something this will give you compiler
warning-treated-as-error
"error: 'NSView' may not respond to 'setEnabled:'"
and will not touch any of these UI elements because they are all contained in
other NSViews (inputRowView_ and storageView_). But like I said, maybe I am
missing something here...it's certainly happened before. :)

+  [cvcInput_ setEnabled:enabled];
+  [monthPopup_ setEnabled:enabled];
+  [yearPopup_ setEnabled:enabled];
+  [storageCheckbox_ setEnabled:enabled];
+}
+
 - (void)setRetriableErrorMessage:(const base::string16&)text {
   NSAttributedString* attributedString =
       constrained_window::GetAttributedLabelString(
           SysUTF16ToNSString(text), kErrorFontStyle, NSNaturalTextAlignment,
           NSLineBreakByWordWrapping);
   [errorLabel_ setAttributedStringValue:attributedString];
   [self performLayoutAndDisplay:YES];
 }
 
 - (void)setPermanentErrorMessage:(const base::string16&)text {
@@ skipping 16 matching lines @@
     }
 
     NSAttributedString* attributedString =
         constrained_window::GetAttributedLabelString(
             SysUTF16ToNSString(text), kErrorFontStyle, NSNaturalTextAlignment,
             NSLineBreakByWordWrapping);
     [permanentErrorLabel_ setAttributedStringValue:attributedString];
   }
 
   [permanentErrorBox_ setHidden:text.empty()];
+  [self setInputsEnabled:NO];
+  [self updateVerifyButtonEnabled];
   [self setRetriableErrorMessage:base::string16()];
 }
 
 - (void)updateVerifyButtonEnabled {
   BOOL enable = ![inputRowView_ isHidden] &&
+                ![[permanentErrorLabel_ stringValue] length] &&

[bondd, 2015/03/26 19:50:06]

Alternatively, this line could be "[cvcInput_ isEnabled] &&"

[groby-ooo-7-16, 2015/03/26 20:17:45]

I like the current one better, because it's more general. The cvcInput will
break if there are ever additional cases that can set an error

[bondd, 2015/03/26 20:33:12]

Acknowledged.

                 bridge_->GetController()->InputCvcIsValid(
                     base::SysNSStringToUTF16([cvcInput_ stringValue])) &&
                 [self expirationDateIsValid];
 
   [verifyButton_ setEnabled:enable];
 }
 
 - (void)onVerify:(id)sender {
   bridge_->GetController()->OnUnmaskResponse(
       base::SysNSStringToUTF16([cvcInput_ stringValue]),
@@ skipping 281 matching lines @@
 
   // Layout inputRowView_.
   [CardUnmaskPromptViewCocoa sizeToFitView:inputRowView_];
   [CardUnmaskPromptViewCocoa verticallyCenterSubviewsInView:inputRowView_];
 
   [self setView:mainView];
   [self performLayoutAndDisplay:NO];
 }
 
 @end