Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Unified Diff: net/http/transport_security_persister_unittest.cc

Issue 103803012: Make HSTS headers not clobber preloaded pins. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase and updated comment. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/transport_security_persister_unittest.cc
diff --git a/net/http/transport_security_persister_unittest.cc b/net/http/transport_security_persister_unittest.cc
index 8c41f9e81daad844049fcef091eea1fcb38b4852..3d3701dcd310b6e883b738eb1ed760aa399df748 100644
--- a/net/http/transport_security_persister_unittest.cc
+++ b/net/http/transport_security_persister_unittest.cc
@@ -68,17 +68,17 @@ TEST_F(TransportSecurityPersisterTest, SerializeData2) {
EXPECT_TRUE(persister_->LoadEntries(output, &dirty));
EXPECT_TRUE(state_.GetDomainState(kYahooDomain, true, &domain_state));
- EXPECT_EQ(domain_state.upgrade_mode,
+ EXPECT_EQ(domain_state.dynamic_sts.upgrade_mode,
TransportSecurityState::DomainState::MODE_FORCE_HTTPS);
EXPECT_TRUE(state_.GetDomainState("foo.yahoo.com", true, &domain_state));
- EXPECT_EQ(domain_state.upgrade_mode,
+ EXPECT_EQ(domain_state.dynamic_sts.upgrade_mode,
TransportSecurityState::DomainState::MODE_FORCE_HTTPS);
EXPECT_TRUE(state_.GetDomainState("foo.bar.yahoo.com", true, &domain_state));
- EXPECT_EQ(domain_state.upgrade_mode,
+ EXPECT_EQ(domain_state.dynamic_sts.upgrade_mode,
TransportSecurityState::DomainState::MODE_FORCE_HTTPS);
EXPECT_TRUE(state_.GetDomainState("foo.bar.baz.yahoo.com", true,
&domain_state));
- EXPECT_EQ(domain_state.upgrade_mode,
+ EXPECT_EQ(domain_state.dynamic_sts.upgrade_mode,
TransportSecurityState::DomainState::MODE_FORCE_HTTPS);
EXPECT_FALSE(state_.GetDomainState("com", true, &domain_state));
}
@@ -173,7 +173,7 @@ TEST_F(TransportSecurityPersisterTest, PublicKeyHashes) {
net::HashValue sha1(net::HASH_VALUE_SHA1);
memset(sha1.data(), '1', sha1.size());
- domain_state.dynamic_spki_hashes.push_back(sha1);
+ domain_state.dynamic_pkp.spki_hashes.push_back(sha1);
EXPECT_FALSE(domain_state.CheckPublicKeyPins(hashes));
@@ -188,14 +188,14 @@ TEST_F(TransportSecurityPersisterTest, PublicKeyHashes) {
bool include_subdomains = false;
state_.AddHSTS(kTestDomain, expiry, include_subdomains);
state_.AddHPKP(kTestDomain, expiry, include_subdomains,
- domain_state.dynamic_spki_hashes);
+ domain_state.dynamic_pkp.spki_hashes);
std::string ser;
EXPECT_TRUE(persister_->SerializeData(&ser));
bool dirty;
EXPECT_TRUE(persister_->LoadEntries(ser, &dirty));
EXPECT_TRUE(state_.GetDomainState(kTestDomain, false, &domain_state));
- EXPECT_EQ(1u, domain_state.dynamic_spki_hashes.size());
- EXPECT_EQ(sha1.tag, domain_state.dynamic_spki_hashes[0].tag);
- EXPECT_EQ(0, memcmp(domain_state.dynamic_spki_hashes[0].data(), sha1.data(),
- sha1.size()));
+ EXPECT_EQ(1u, domain_state.dynamic_pkp.spki_hashes.size());
+ EXPECT_EQ(sha1.tag, domain_state.dynamic_pkp.spki_hashes[0].tag);
+ EXPECT_EQ(0, memcmp(domain_state.dynamic_pkp.spki_hashes[0].data(),
+ sha1.data(), sha1.size()));
}

Powered by Google App Engine
This is Rietveld 408576698