Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1038013002: Replace tabs with spaces in gyp file. (Closed)

Created:
5 years, 9 months ago by Torne
Modified:
5 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace tabs with spaces in gyp file. Part of components/sessions.gypi has ended up indented with tabs; replace with spaces before refactoring. BUG= NOTRY=true Committed: https://crrev.com/4ff34e7f21c7002a2b1461c3182419a76ca9c631 Cr-Commit-Position: refs/heads/master@{#322554}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -58 lines) Patch
M components/sessions.gypi View 1 chunk +58 lines, -58 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Torne
Do you object to me fixing the whitespace here? Noticed the inconsistency when trying to ...
5 years, 9 months ago (2015-03-26 18:26:33 UTC) #2
sky
One question, does gn format replace the tabs with spaces?
5 years, 9 months ago (2015-03-26 19:40:47 UTC) #3
sky
LGTM - my question about gn format is more that we should make gn format ...
5 years, 9 months ago (2015-03-26 19:45:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1038013002/1
5 years, 9 months ago (2015-03-27 11:36:12 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-27 11:36:45 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4ff34e7f21c7002a2b1461c3182419a76ca9c631 Cr-Commit-Position: refs/heads/master@{#322554}
5 years, 9 months ago (2015-03-27 11:37:36 UTC) #8
Torne
5 years, 9 months ago (2015-03-27 11:37:59 UTC) #9
Message was sent while issue was closed.
On 2015/03/26 19:40:47, sky wrote:
> One question, does gn format replace the tabs with spaces?

gn's parser just rejects tabs in the first place and refuses to touch the file
at all. gn format does the same it seems. So, it should not be possible for gn
files to end up containing tabs :)

Powered by Google App Engine
This is Rietveld 408576698