Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 1038003002: Use variadic template for screen handler's AddCallback. (Closed)

Created:
5 years, 9 months ago by xiyuan
Modified:
5 years, 9 months ago
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, Mattias Nissler (ping if slow)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use variadic template for screen handler's AddCallback. BUG=none Committed: https://crrev.com/3d5f51b28af6131b5dec279f60a029af26fed037 Cr-Commit-Position: refs/heads/master@{#322444}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -147 lines) Patch
M chrome/browser/ui/webui/chromeos/login/base_screen_handler.h View 1 chunk +4 lines, -55 lines 0 comments Download
M components/login/base_screen_handler_utils.h View 2 chunks +16 lines, -73 lines 0 comments Download
M components/login/base_screen_handler_utils.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M components/webui_generator/web_ui_view.h View 1 chunk +4 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
xiyuan
Variadicc tempate for AddCallback in a separate CL. :) I am not expert of templates ...
5 years, 9 months ago (2015-03-26 18:29:42 UTC) #2
dzhioev (left Google)
On 2015/03/26 18:29:42, xiyuan wrote: > Variadicc tempate for AddCallback in a separate CL. :) ...
5 years, 9 months ago (2015-03-26 18:53:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1038003002/1
5 years, 9 months ago (2015-03-26 19:21:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-26 19:24:12 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 19:24:49 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3d5f51b28af6131b5dec279f60a029af26fed037
Cr-Commit-Position: refs/heads/master@{#322444}

Powered by Google App Engine
This is Rietveld 408576698