Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issue 1037843003: ozone: evdev: Allow setting slot values in EventDeviceInfo (Closed)

Created:
5 years, 9 months ago by spang
Modified:
5 years, 9 months ago
Reviewers:
kpschoedel
CC:
chromium-reviews, kalyank, tdresser+watch_chromium.org, jdduke+watch_chromium.org, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ozone: evdev: Allow setting slot values in EventDeviceInfo Currently we stub out TouchEventConverterEvdev::Initialize() in the tests, but we now need to fix that because that's where we'll detect if a device is MT-capable. Initialize() looks up slot values, so we'll need to populate them from captured device descriptions in CapabilitiesToDeviceInfo(). The initial state is all zeroes except for tracking id (this matches kernel initial slot state). While we're here, clean up a bunch of the slot values setup & access code in EventDeviceInfo. BUG=461518 TEST=events_unittests Committed: https://crrev.com/8765e8c490efe374ced20fe590ad75cbf0dc5089 Cr-Commit-Position: refs/heads/master@{#322580}

Patch Set 1 #

Patch Set 2 : fix ABS_MT_TRACKING_ID init #

Patch Set 3 : define ABS_MT_TOOL_Y if missing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -40 lines) Patch
M ui/events/ozone/evdev/event_device_info.h View 1 2 4 chunks +15 lines, -7 lines 0 comments Download
M ui/events/ozone/evdev/event_device_info.cc View 5 chunks +47 lines, -27 lines 0 comments Download
M ui/events/ozone/evdev/event_device_test_util.cc View 1 1 chunk +12 lines, -0 lines 0 comments Download
M ui/events/ozone/evdev/touch_event_converter_evdev.cc View 1 chunk +11 lines, -6 lines 0 comments Download

Messages

Total messages: 22 (12 generated)
spang
on top of https://codereview.chromium.org/1019793011/
5 years, 9 months ago (2015-03-25 22:55:53 UTC) #2
kpschoedel
LGTM
5 years, 9 months ago (2015-03-26 15:16:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1037843003/20001
5 years, 9 months ago (2015-03-26 15:56:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1037843003/20001
5 years, 9 months ago (2015-03-26 15:59:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1037843003/20001
5 years, 9 months ago (2015-03-26 16:27:29 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/1776)
5 years, 9 months ago (2015-03-26 16:57:51 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1037843003/40001
5 years, 9 months ago (2015-03-26 17:15:19 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1037843003/40001
5 years, 9 months ago (2015-03-27 15:03:35 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-27 15:04:18 UTC) #21
commit-bot: I haz the power
5 years, 9 months ago (2015-03-27 15:04:45 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8765e8c490efe374ced20fe590ad75cbf0dc5089
Cr-Commit-Position: refs/heads/master@{#322580}

Powered by Google App Engine
This is Rietveld 408576698